1757 mobx new routing#4679
Conversation
Groups are also links now explorerPanelIsVisible now ties into location routing
Visibility was not toggled correctly when waiting for animation to finish
# Conflicts: # lib/ReactViewModels/ViewState.js # lib/ReactViews/DataCatalog/CatalogItem.jsx # lib/ReactViews/SidePanel/SidePanel.jsx # lib/ReactViews/StandardUserInterface/StandardUserInterface.jsx # package.json # test/ReactViews/StandardUserInterfaceSpec.jsx
# Conflicts: # doc/customizing/client-side-config.md # lib/ReactViewModels/ViewState.js # lib/ReactViews/DataCatalog/CatalogItem.jsx # lib/ReactViews/SidePanel/SidePanel.jsx # lib/ReactViews/StandardUserInterface/StandardUserInterface.jsx # package.json # test/ReactViews/StandardUserInterfaceSpec.jsx
|
@na9da as discussed, let me address the pr comments here when I get a moment, and you can start working on the other 2 points in the desc. Re: the second point, would just be checking that all the links that link you to certain routes are anchor elements - check the prod https://map.drought.gov.au/ for instances, the basic check is turn off javascript and see if you can traverse the catalog from |
# Conflicts: # buildprocess/karma-saucelabs.conf.js # lib/ReactViews/Preview/DataPreviewSections.jsx # lib/ReactViews/SidePanel/Branding.jsx
|
An error pops up on start when loading a static URL. This is because |
|
Re:
I'm not quite sure how to tackle this, we want to differentiate when a slash is for routing purposes, or if it's for ID purposes. (e.g. we need to be able to have confidence to always encode and decode a URL, without doing any double encoding/decoding etc). Ideally we don't use such confusing characters in IDs, but is unfortunately a side effect of having IDs like If we didn't encode it as such, we would end up with URLs like |
Great to see you've reproduced what I had, you'll have to investigate why this is an issue in v8 but not the v7 port (I'm thinking why is it not an issue in v7?*) |
|
For greater performance |
|
Fixes for styling and proxying - TerriaJS/TerriaMap#496 |
|
Approving! |
…routing"" This reverts commit 093c61b. # Conflicts: # lib/ReactViews/Preview/DataPreview.jsx

What this PR does
Addresses the first half (routing) of v7-maps-running-prerendering on v8
https://github.com/TerriaJS/drought-map/issues/195
(and the first half of porting #3494)
Additionally, I've disabled the IE11 tests given IE11 doesn't actually work for v8 at the moment.
What this PR doesn't do
As part of another issue/pr,
Checklist