Skip to content

PR opened by mistake - #13970

Closed
venturqx wants to merge 107 commits into
TeamNewPipe:refactorfrom
venturqx:update-0.29-issues
Closed

PR opened by mistake#13970
venturqx wants to merge 107 commits into
TeamNewPipe:refactorfrom
venturqx:update-0.29-issues

fix: auth

54093d8
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 29, 2026 in 1m 33s

Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 136 in app/src/main/java/org/schabi/newpipe/fragments/list/kiosk/TournesolFilterController.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Convert this getter to a "get()" on the property "currentWeightImportance". 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAUpW6dv3luY_ZYu&open=AaGISAUpW6dv3luY_ZYu&pullRequest=13970

Check warning on line 143 in app/src/main/java/org/schabi/newpipe/fragments/list/kiosk/TournesolFilterController.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Convert this getter to a "get()" on the property "currentWeightBackfireRisk". 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAUpW6dv3luY_ZY1&open=AaGISAUpW6dv3luY_ZY1&pullRequest=13970

Check failure on line 69 in app/src/main/java/org/schabi/newpipe/views/TournesolScoreCard.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "importance" 4 times. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAeQW6dv3luY_ZZv&open=AaGISAeQW6dv3luY_ZZv&pullRequest=13970

Check failure on line 1619 in app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAVeW6dv3luY_ZZJ&open=AaGISAVeW6dv3luY_ZZJ&pullRequest=13970

Check warning on line 989 in app/src/main/java/org/schabi/newpipe/fragments/detail/compare/CompareCompactScreen.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure that using this pseudorandom number generator is safe here. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAVJW6dv3luY_ZZA&open=AaGISAVJW6dv3luY_ZZA&pullRequest=13970

Check warning on line 128 in app/src/main/java/org/schabi/newpipe/fragments/list/kiosk/TournesolFilterController.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Convert this getter to a "get()" on the property "currentIncludeLowScoreVideos". 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAUpW6dv3luY_ZYp&open=AaGISAUpW6dv3luY_ZYp&pullRequest=13970

Check warning on line 141 in app/src/main/java/org/schabi/newpipe/fragments/list/kiosk/TournesolFilterController.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Convert this getter to a "get()" on the property "currentWeightDiversityInclusion". 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAUpW6dv3luY_ZYz&open=AaGISAUpW6dv3luY_ZYz&pullRequest=13970

Check warning on line 233 in app/src/main/java/org/schabi/newpipe/fragments/detail/compare/CompareCompactScreen.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "hasSuggestions" local variable. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAVJW6dv3luY_ZZB&open=AaGISAVJW6dv3luY_ZZB&pullRequest=13970

Check warning on line 114 in app/src/main/java/org/schabi/newpipe/fragments/list/kiosk/TournesolKioskFragment.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 15 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAUhW6dv3luY_ZYi&open=AaGISAUhW6dv3luY_ZYi&pullRequest=13970

Check warning on line 103 in app/src/main/java/org/schabi/newpipe/info_list/holder/StreamInfoItemHolder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "textColor" local variable. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAeWW6dv3luY_ZZ3&open=AaGISAeWW6dv3luY_ZZ3&pullRequest=13970

Check warning on line 140 in app/src/main/java/org/schabi/newpipe/fragments/list/kiosk/TournesolFilterController.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Convert this getter to a "get()" on the property "currentWeightEngaging". 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAUpW6dv3luY_ZYy&open=AaGISAUpW6dv3luY_ZYy&pullRequest=13970

Check warning on line 358 in app/src/main/java/org/schabi/newpipe/fragments/MainFragment.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move the conditional expression inside this operation. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAXvW6dv3luY_ZZV&open=AaGISAXvW6dv3luY_ZZV&pullRequest=13970

Check failure on line 67 in app/src/main/java/org/schabi/newpipe/views/TournesolScoreCard.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "reliability" 4 times. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAeQW6dv3luY_ZZq&open=AaGISAeQW6dv3luY_ZZq&pullRequest=13970

Check warning on line 91 in app/src/main/java/org/schabi/newpipe/fragments/list/kiosk/DefaultKioskFragment.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 15 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAUlW6dv3luY_ZYk&open=AaGISAUlW6dv3luY_ZYk&pullRequest=13970

Check warning on line 189 in app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge chained "if" statements into a single "when" statement. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAVeW6dv3luY_ZZK&open=AaGISAVeW6dv3luY_ZZK&pullRequest=13970

Check warning on line 835 in app/src/main/java/org/schabi/newpipe/views/TournesolScoreCard.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly cast this "int" to "float" to document potential precision loss. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAeQW6dv3luY_ZZi&open=AaGISAeQW6dv3luY_ZZi&pullRequest=13970

Check failure on line 74 in app/src/main/java/org/schabi/newpipe/views/TournesolScoreCard.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "better_habits" 4 times. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAeQW6dv3luY_ZZs&open=AaGISAeQW6dv3luY_ZZs&pullRequest=13970

Check warning on line 1163 in app/src/main/java/org/schabi/newpipe/fragments/detail/CompareFragment.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless null check, it always fails. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAVnW6dv3luY_ZZL&open=AaGISAVnW6dv3luY_ZZL&pullRequest=13970

Check warning on line 783 in app/src/main/java/org/schabi/newpipe/views/TournesolScoreCard.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly cast this "int" to "float" to document potential precision loss. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAeQW6dv3luY_ZZh&open=AaGISAeQW6dv3luY_ZZh&pullRequest=13970

Check failure on line 100 in app/src/main/java/org/schabi/newpipe/info_list/holder/StreamInfoItemHolder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAeWW6dv3luY_ZZ2&open=AaGISAeWW6dv3luY_ZZ2&pullRequest=13970

Check warning on line 781 in app/src/main/java/org/schabi/newpipe/views/TournesolScoreCard.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly cast this "int" to "float" to document potential precision loss. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAeQW6dv3luY_ZZf&open=AaGISAeQW6dv3luY_ZZf&pullRequest=13970

Check failure on line 38 in app/src/main/java/org/schabi/newpipe/ui/components/items/stream/StreamGridItem.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 46 to the 45 allowed. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISASVW6dv3luY_ZYf&open=AaGISASVW6dv3luY_ZYf&pullRequest=13970

Check warning on line 1266 in app/src/main/java/org/schabi/newpipe/fragments/detail/CompareFragment.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure that using this pseudorandom number generator is safe here. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAVnW6dv3luY_ZZQ&open=AaGISAVnW6dv3luY_ZZQ&pullRequest=13970

Check failure on line 20 in app/src/main/java/org/schabi/newpipe/util/TournesolSecretExtractor.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 32 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAcBW6dv3luY_ZZZ&open=AaGISAcBW6dv3luY_ZZZ&pullRequest=13970

Check warning on line 70 in app/src/main/java/org/schabi/newpipe/fragments/list/kiosk/TournesolFilterFragment.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 15 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AaGISAUvW6dv3luY_ZY3&open=AaGISAUvW6dv3luY_ZY3&pullRequest=13970
View more details on SonarQubeCloud