Repository navigation
Fix: Crash on Samsung Dex when trying to click on a popup menu (e.g. resolution, etc...) - #13958
Open
mathildalabs wants to merge 3 commits into
Open
mathildalabs wants to merge 3 commits into
mathildalabs wants to merge 3 commits into
Conversation
github-actions
Bot
added
size/medium
This comment was marked as low quality.
This comment was marked as low quality.
TobiGr
added
device/software specific
Contributor
|
Thank you for the contribution! Is it part of the yearly ANU assignement? If yes, I'll try to review it before the deadline. |
Author
|
@TobiGr No, it is not. You can review it at your own pace. Thank you. |
TobiGr
reviewed
Oct 26, 2026
TobiGr
left a comment
TobiGr
left a comment
Contributor
There was a problem hiding this comment.
thank you. I just have a minor comment.
Contributor
There was a problem hiding this comment.
please write new files in kotlin. we are in the middle of a java to kotlin conversion and would need to convert this file later anyway.
Please also add this SPDX Copyright / license header to the file:
/*
* SPDX-FileCopyrightText: 2026 NewPipe contributors <https://newpipe.net>
* SPDX-License-Identifier: GPL-3.0-or-later
*/
github-actions
Bot
added
size/small
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
When a user using the phone connected on a external monitor using Samsung Dex, can now click to change the resolution and on any other popup menu, without the app crashing. The second Issue I mention below i have not tested it, but appears to be the exact same cause.
Fixes the following issue(s)
Testing/QA
Devices
Steps for testing
APK for testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence