Repository navigation
Migrate Update settings screen to Compose (KMP) - #13932
Closed
awaisdev5765 wants to merge 4 commits into
Closed
awaisdev5765 wants to merge 4 commits into
awaisdev5765 wants to merge 4 commits into
Conversation
Implements TeamNewPipe#8981 (long-press Clear cache action on the app icon) and partially implements TeamNewPipe#10448 (keyboard shortcuts: space/media keys for play-pause, J/L for seek, M for mute) as a gift to the project.
Hardware keyboard users reported that arrow keys initiate focus jumps between player UI elements instead of seeking. On non-TV devices, LEFT/RIGHT now seek and D-pad-center toggles playback. TV D-pad navigation behavior is unchanged.
Adds ContentSettingsScreen/ViewModel/Preferences to the shared module following the established settings-screen pattern, wires it into the settings home navigation (SettingsCategoryType.CONTENT), and introduces ContentActions for platform-specific behavior. Image cache wipe, restricted-mode cookies and localization reload are marked as TODOs — they need app-module hooks. Legacy ContentSettingsFragment behavior is preserved until full migration.
Adds UpdateSettingsScreen/ViewModel/Preferences to the shared module (auto-update toggle + manual update check), wires it into the settings home navigation (SettingsCategoryType.UPDATES), and introduces UpdateActions for the NewVersionWorker hook, marked TODO pending an app-module bridge.
github-actions
Bot
added
size/giant
Contributor
|
Please link this PR to an existing issue you are assigned to. Assignees are expected to discuss the details of the PR beforehand. This PR will be closed if it is not linked to an issue. |
|
Contributor
|
This will not receive a review from me until it is properly tested. |
TobiGr
added
waiting for author
theimpulson
added
the
spam
Member
|
Closing due to violating contribution guidelines of NewPipe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Follow-up to #13931, continuing the Compose/KMP migration tracked in #11198:
UpdateSettingsScreen(Compose) +UpdateSettingsViewModel(@KoinViewModel) +UpdatePreferences: the auto-update toggle (legacy defaultfalsefromupdate_settings.xmlpreserved) and the manual "Check for updates" row.UpdateActionsinterface with anAndroidUpdateActionsactual:enqueueUpdateCheck(manual)is deliberately marked TODO becauseNewVersionWorkerlives in the app module, which the shared module can't reference — same hooks approach as the Content settings PR.Destination,navModule(), and the settings home:SettingsCategoryType.UPDATESnow resolves one of the// TODO: wire remaining sub-screenscases inSettingsHomeScreen.strings.xml.The legacy
UpdateSettingsFragmentremains untouched and authoritative until full migration.Before/After Screenshots/Screen Record
NewVersionWorkerhook is wired).Fixes the following issue(s)
Relies on the following changes
Testing/QA
Devices
Steps for testing
AndroidUpdateActions) and a "Checking for updates…" snackbar appearsAPK for testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence