Repository navigation
Popup restores bad size #4296
Description
Version
- b69e477
- 0.19.8
Steps to reproduce the bug
- Open a video in popup mode while being in portrait mode
- Rotate device to get in landscape and enlarge the popup to have a bigger height than the device width
3.1. Rotate to get back in landscape -> you'll have black bars at the top and bottom of the popup
3.2. [OR] Close the popup
3.2.1. rotate back to portrait mode -> player starts to play
3.2.2. Stop the player
3.2.3. Start the popup -> popup has the size from 2. and is only partly on the screen.
Expected behavior
3.1. No black bars
3.2.1. Player does not start
3.2.3. Popup is not wider than the device width
Screenshots/Screen recordings
Reacted by ShareASmile
Activity
avently commentedon Sep 20, 2020
Why did you marked the issue
[Unified]if the same situation happens in 0.19.8?[-][Unified] Popup restores bad size[/-][+]Popup restores bad size[/+]DoaaIkzamia commentedon Nov 13, 2020
Good afternoon all,
I need to join you to fixed this bug, Can I ?
opusforlife2 commentedon Nov 13, 2020
@DoaaIkzamia You're welcome to open a PR. :D
DoaaIkzamia commentedon Jan 12, 2021
Dear @opusforlife2 and @TobiGr ,
About those bugs which you mention in this job issue, I studied the code (version 19.8) and tried to solve them one by one and I started with this issue (3.2.1) it seems simplest than others.
I wanna to ask you if you make paused for this video before closed pop up mode ? or without paused?
Thanks.
Update VideoPlayerImpl.java
DoaaIkzamia commentedon Jan 14, 2021
Dears,
About this bugs, You now that the version 19.8 is not available right now ((That exact version can't be run anymore because of YouTube changes. ))
Attached the video show you how it fixed it.
https://drive.google.com/file/d/1qDF-UjBEIDHosgxiLaTtMyX7BVMg9fGV/view?usp=sharing
Regards,
Doaa
rancidfrog commentedon Jun 11, 2021
Pop-up does not always keep the same size and position if you pause video and switch screen off and on. If you pause video into lockscreen and reopen player, no rotation, many times the screen size and position resets.
Size and position should be persistent
Version 0.21.3
AudricV commentedon Feb 8, 2024
Is it still an issue on 0.26.1?
github-actions commentedon Feb 23, 2024
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.
ShareASmile commentedon Oct 27, 2026
3.1. Rotate to get back in landscape -> you'll have black bars at the top and bottom of the popup
3.2. [OR] Close the popup
3.2.1. rotate back to portrait mode -> player starts to play
3.2.2. Stop the player
3.2.3. Start the popup -> popup has the size from 2. and is only partly on the screen.
Reopening as 3.1 and 3.2.3 still happens but on each alternate try.
SAMPATH00247 commentedon Oct 28, 2026
Hi! I'd like to work on the remaining popup sizing issue as my first contribution to NewPipe. I noticed the earlier fix in commit c4f21c9. I'll reproduce the remaining issue on the current version and check the existing implementation first. Is there a particular part you'd recommend investigating?