Skip to content

test: cover linked PR state parsing - #94

Merged
TanbirRamim merged 2 commits into
TanbirRamim:mainfrom
Pratham2511:codex/test-linked-pr-states
Oct 10, 2026
Merged

TanbirRamim merged 2 commits into
TanbirRamim:mainfrom
Pratham2511:codex/test-linked-pr-states

Conversation

@Pratham2511

Copy link
Copy Markdown
Contributor

Adds direct tests for linked_pr_states() covering missing timeline data, null nodes, PRs under subject and source, and entries without a state. Mixed fixtures check that valid states are retained in order. All changes are in scripts/test_radar.py.

Closes #76

  • I commented on the issue and got the go-ahead (or it's a small fix with no issue).
  • I did not edit generated files (issues/by-*, data/, site/data/, the README stats block).
  • For pipeline changes, python3 -m unittest discover scripts and ruff check scripts pass.

Verification: all 41 tests pass on Python 3.11.17, 3.12.14, and 3.13.5 against current upstream main. Ruff 0.17.0 lint and format checks and offline Markdown links pass. The offline render smoke test and website script syntax check also passed during review. Ruff was run directly because uvx is unavailable.

AI assistance was used to write the tests and prepare this PR. The patch received independent local review, and the assertions detected eight temporary in-memory parser mutations.

Add direct unittest coverage for missing timeline data, null nodes, PRs under subject and source, and entries without a state. Assert exact outputs to verify valid states remain in timeline order.
Copilot AI balanced review requested due to automatic review settings October 10, 2026 17:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@TanbirRamim

Copy link
Copy Markdown
Owner

thanks @Pratham2511, these are tidy. I added one more for the case that happens most in practice: another issue mentioning this one. the query only asks for PR fields, so that comes back as an empty source, and the issue has to stay listed.

@TanbirRamim
TanbirRamim merged commit 79d68f0 into TanbirRamim:main Oct 10, 2026
6 checks passed
@TanbirRamim

Copy link
Copy Markdown
Owner

merged, thanks! if the radar has been useful to you, a star helps other newcomers find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests for linked_pr_states()

3 participants