Repository navigation
test: cover linked PR state parsing - #94
Merged
TanbirRamim merged 2 commits intoOct 10, 2026
Merged
Conversation
Add direct unittest coverage for missing timeline data, null nodes, PRs under subject and source, and entries without a state. Assert exact outputs to verify valid states remain in timeline order.
Owner
|
thanks @Pratham2511, these are tidy. I added one more for the case that happens most in practice: another issue mentioning this one. the query only asks for PR fields, so that comes back as an empty source, and the issue has to stay listed. |
Owner
|
merged, thanks! if the radar has been useful to you, a star helps other newcomers find it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds direct tests for
linked_pr_states()covering missing timeline data, null nodes, PRs undersubjectandsource, and entries without a state. Mixed fixtures check that valid states are retained in order. All changes are inscripts/test_radar.py.Closes #76
issues/by-*,data/,site/data/, the README stats block).python3 -m unittest discover scriptsandruff check scriptspass.Verification: all 41 tests pass on Python 3.11.17, 3.12.14, and 3.13.5 against current upstream main. Ruff 0.17.0 lint and format checks and offline Markdown links pass. The offline render smoke test and website script syntax check also passed during review. Ruff was run directly because
uvxis unavailable.AI assistance was used to write the tests and prepare this PR. The patch received independent local review, and the assertions detected eight temporary in-memory parser mutations.