Skip to content

Fix missing activation checkpointing (recompute) parameters in bridge mode #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XJL010622 wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −0
Open

Fix missing activation checkpointing (recompute) parameters in bridge mode #1833

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
847e611
Fix missing activation checkpointing parameters in bridge mode
Apr 14, 2026
f4851fe
Merge branch 'main' into fix-bridge-recompute
XJL010622 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions slime/backends/megatron_utils/model_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,15 @@ def wrapped_model_provider(
provider.num_layers_in_first_pipeline_stage = args.decoder_first_pipeline_num_layers
if getattr(args, "decoder_last_pipeline_num_layers", None) is not None:
provider.num_layers_in_last_pipeline_stage = args.decoder_last_pipeline_num_layers

recompute_fields = (
"recompute_granularity",
"recompute_method",
"recompute_num_layers")

for field in recompute_fields:
if hasattr(args, field) and getattr(args, field) is not None:
setattr(provider, field, getattr(args, field))
provider.finalize()

if role == "critic":
Expand Down