Fixed set mode of raw reflection values (mode numbered zero) in simulator for nxt light sensor#1
Closed
THEb0nny wants to merge 1 commit into
Closed
Fixed set mode of raw reflection values (mode numbered zero) in simulator for nxt light sensor#1THEb0nny wants to merge 1 commit into
THEb0nny wants to merge 1 commit into
Conversation
When we find the DAL.CONN_NXT_DUMB sensor, we additionally call setAnalogMode(), which passes the sensor mode to the simulator. Perhaps the same thing needs to be done for DAL.CONN_INPUT_DUMB, but there is only one analog sensor ev3 (touch sensor), and it works without this change.
THEb0nny
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsoft/pxt-ev3#1045