Skip to content

prepare for evaluation phase and run more data - #91

Merged
KrisThielemans merged 6 commits into
mainfrom
mMR_ACR
Sep 29, 2024
Merged

prepare for evaluation phase and run more data#91
KrisThielemans merged 6 commits into
mainfrom
mMR_ACR

Conversation

@casperdcl

@casperdcl casperdcl commented Aug 28, 2024 •
edited by KrisThielemans
Loading

Copy link
Copy Markdown
Member

@casperdcl casperdcl added enhancement New feature or request data labels Aug 28, 2024
@casperdcl casperdcl mentioned this pull request Sep 2, 2024
Closed
@casperdcl
casperdcl force-pushed the mMR_ACR branch 2 times, most recently from c457221 to 34b28ee Compare September 11, 2024 14:30
KrisThielemans
KrisThielemans reviewed Sep 11, 2024
View reviewed changes
Comment thread petric.py Outdated
@casperdcl casperdcl mentioned this pull request Sep 12, 2024
Merged
@casperdcl
casperdcl force-pushed the mMR_ACR branch 2 times, most recently from 06cb7cf to 55d009b Compare September 13, 2024 14:28
@casperdcl casperdcl mentioned this pull request Sep 25, 2024
Merged
KrisThielemans
KrisThielemans requested changes Sep 26, 2024
View reviewed changes

@KrisThielemans KrisThielemans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As computing the metrics does take time, let's set the interval of computing metrics to 3 to avoid overloading the system.

We will need to compute them every update for the final evaluation.

Otherwise, this PR is good to go.

KrisThielemans
KrisThielemans reviewed Sep 29, 2024
View reviewed changes
Comment thread petric.py Outdated
KrisThielemans
KrisThielemans reviewed Sep 29, 2024
View reviewed changes

@KrisThielemans KrisThielemans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@casperdcl can we merge this before PETRIC is over for participants to get more final feedback? Note the suggested change to compute metrics every 3 updates.

@KrisThielemans
KrisThielemans marked this pull request as ready for review September 29, 2024 10:44
@KrisThielemans KrisThielemans changed the title evaluation phase prepare for evaluation phase and run more data Sep 29, 2024
@KrisThielemans
KrisThielemans merged commit e549237 into main Sep 29, 2024
@KrisThielemans
KrisThielemans deleted the mMR_ACR branch September 29, 2024 12:56
casperdcl
casperdcl commented Sep 30, 2024
View reviewed changes

@casperdcl casperdcl left a comment •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we merge this before PETRIC is over for participants to get more final feedback

hah not really much time for them to do anything about it. Especially given that people don't work on Sunday.

Also inconsistent interval @KrisThielemans ...

Comment thread petric.py
Comment thread petric.py
@KrisThielemans

KrisThielemans commented Sep 30, 2024

Copy link
Copy Markdown
Member

sorry. mad rush. Please correct as you see fit. I won't touch it anymore.

@casperdcl casperdcl mentioned this pull request Oct 1, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KrisThielemans KrisThielemans KrisThielemans requested changes

Assignees

@KrisThielemans KrisThielemans

@casperdcl casperdcl

Labels

data enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@casperdcl @KrisThielemans