-
Notifications
You must be signed in to change notification settings - Fork 397
Add NVLink #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danbedford
wants to merge
32
commits into
Syllo:master
Choose a base branch
from
danbedford:nvlink
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add NVLink #469
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
97fdf09
feat: add NVLink data extraction via NVML API
danbedford e47bc48
feat: add NVLink display to nvtop interface
danbedford 2ef64f0
fix: replace non-existent NVML symbols with correct API calls
danbedford 110a9cb
refactor: NVLink flat struct, CLI throughput, conditional layout
danbedford 1b98806
feat: add NVLink error/correction counters, fix display layout, renam…
danbedford 3f0face
fix: baseline reset for NVLink error counters, fix nvmlFieldValue_t l…
danbedford 02464d6
feat: switch NVLink throughput from data-only to raw counters (--gett…
danbedford 336ee07
docs: add TODO for datacenter GPU NVML API path, remove stale EMA com…
danbedford fc9e548
revert: remove EMA smoothing from NVLink throughput, prioritize raw a…
danbedford 4b1f9f2
feat: increase NVLink max links from 18 to 36, hardcode 2s CLI poll i…
danbedford 61a31dc
fix: add missing delwin for shader_cores/l2_cache_size/exec_engines, …
danbedford baa21a2
fix: priority-2 code quality improvements
danbedford 737d4f0
feat: cache NVLink link count and version to avoid re-probing every r…
danbedford 6f1183d
perf: skip NVLink re-probing when already detected, with monitored-se…
danbedford 1d11cda
perf: cache full nvlink_info struct in refresh path, optimize draw pa…
danbedford b480c24
feat: add NVLink 6.0 (Rubin) version mapping for future-proofing
danbedford 007c4ee
feat: detect and display NVLink-supported GPUs with 0 active links
danbedford 4e2ff56
fix: count only active NVLink links, not physical slots with inactive…
danbedford 08ca032
fix: account for NVLink window width in device_length() even with 0 a…
danbedford a527583
Fix: nvtop_set_nvlink_probe() overwrites any_device_has_nvlink_active
danbedford 344e5a6
Fix: device_length() should not expand panel for NVLink 0-link case
danbedford 4c29a4a
Fix: fan display format should use any_device_has_nvlink_active, not …
danbedford 7b4987a
fix: guard NVLink functions with vendor check to avoid container_of o…
danbedford 139d585
fix: device_length() should not expand panel for NVLink active links
danbedford 50d51b7
fix: two-tier flag consistency and monitored-set-change state reset
danbedford 03a65f3
# NVTop NVLink Fork - Changelog
danbedford f6955ee
Merge branch 'master' into nvlink
Syllo 666ffed
feat: address PR #469 maintainer review comments
danbedford 47a6cf8
fix: replace #include nvml.h with manual nvmlFieldValue_t typedef
danbedford b97dac8
fix: use {0} initializer for nvl_info in draw_devices() NVLink display
danbedford a226ed7
feat: add NVML field 160 ECC data errors to batched NVLink query
danbedford df42cc2
ui: use 2-letter labels for NVLink counters (FL/EE/CR)
danbedford File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to define these functions in another file (fallback ones returning unsupported/false/0) for when nvtop is not being compiled with NVIDIA support enabled. Currently they are only available in
extract_gpuinfo_nvidia.c.I would advise creating a new
.cfile and compile it only whenNVIDIA_SUPPORTisOFFThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Created
src/nvlink_nvidia_disabled.cwith 4 no-op stub functions:nvtop_get_nvlink_info()— returns 0nvtop_get_nvlink_error_counts()— returns falsenvtop_probe_nvlink_list()— returns falsenvtop_reset_nvlink_cache()— no-opThe stub file is wired into
src/CMakeLists.txtin theelse(NVIDIA_SUPPORT)branch so it is only compiled when NVIDIA support is disabled. You originally mentioned 5 functions in your review, but the 5th (nvtop_set_nvlink_probe) was removed entirely per your suggestion in Comment 7, so there are now 4.See commit
666ffed.