Skip to content

Add graphical attachment mappings and document removal - #1073

Merged
nonprofittechy merged 3 commits into
mainfrom
fix/editor-attachment-documents
Sep 18, 2026
Merged

nonprofittechy merged 3 commits into
mainfrom
fix/editor-attachment-documents

Conversation

@nonprofittechy

@nonprofittechy nonprofittechy commented Sep 18, 2026

Copy link
Copy Markdown
Member

The /al/editor workflow now supports deleting documents from template setup and editing attachment field mappings graphically.

  • Remove a document from one bundle, all downloads, or the interview. Deletion removes its attachment, title, declaration, and bundle references while retaining the uploaded template and questions. Custom code that refers to the deleted document still needs review.
  • Inspect PDF/DOCX template fields and edit text or conditional Mako expressions with variable autocomplete. Missing PDF mappings are flagged; DOCX implicit variables and dynamic mappings are explained. Complex mappings remain editable in YAML mode.
  • Save question edits on screens containing attachments without dropping the attachment YAML. Handle empty collections, blank fields, and explicit YAML null values when adding mappings.
  • Preserve comments and surrounding source during mapping edits, check revisions before saving, and handle commented attachments and similarly named documents during deletion.

Validation: 81 focused tests passed, including source preservation and frontend regression coverage. The full commit hooks also passed: Black, mypy, JavaScript formatting/lint/type checks, and pytest. The YAML interview hook had no applicable changed files.

Fixes #1060.
Fixes #1018.

@nonprofittechy
nonprofittechy merged commit 0a54553 into main Sep 18, 2026
9 checks passed
@nonprofittechy
nonprofittechy deleted the fix/editor-attachment-documents branch September 18, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It should be possible to delete an attachment from an interview from the template setup page /al/editor: attachment blocks have no graphical editor

1 participant