`pkg_type == "both"` is a comparison, not an assignment

[nonprofittechy]

pkg_type == "both" is a comparison, not an assignment, so this block does not actually set the default package type when search_type is not compare_version. This likely leaves pkg_type unchanged/unset and can break downstream logic that expects it to be set. Use an assignment so the default is applied.

    pkg_type = "both"

Originally posted by @Copilot in #191 (comment)

[nonprofittechy]

FWIW, perhaps we should remove the package scanner--it's not something that's used regularly. Alternatively, we should improve its robustness.

[BryceStevenWilley]

I missed this one. I think there's still a need for the package scanner, but not in its current form. Something like a dry-run of the package updater (https://github.com/SuffolkLITLab/docassemble-ALDashboard/blob/main/docassemble/ALDashboard/data/questions/update_packages.yml) would be good, and it would make more sense as a part of that tool.

[nonprofittechy]

Yes, we also need to update the package updater tool and the installation tool so it really handles all of the standardized configuration items we have now. it's a few years stale