Catch al_custom_error_screen errors - #1116
Conversation
|
Related to #1111 in that it would have the same fix, but I don't know how to reproduce that particular screen. |
plocket
left a comment
There was a problem hiding this comment.
Sorry this has taken so long. Since this is obstructive at the moment, and you've tested it, let's merge it and I can keep working on the outstanding issues.
Related to ALKiln setting a three-part date, thus needing an update to ALKiln? Or related to docassemble-AssemblyLine developing a custom default for AL's three-part date, thus not requiring a change to ALKiln? Or something else? |
The issue I linked to (#1111) was about detecting another error screen, one that says "GithubException: You must be an org admin or have the actions secrets...", and I just didn't know where that screen happens in docassemble. And thanks for linking #656, missed that we already had an issue open for this. |
[Addresses #656]
Reason for this PR
The custom AL screens are not recognized as actual error screens, so Kiln will attempt to continue navigating when it sees them, even when all it can do is stay on the same screen. This wastes
MAX_TIMEOUTminutes each time the interviews fail, instead of recognizing the failure immediately.This fix:
And I tap to continuemultiple times, the error is checked, but Kiln doesn't do anything with it and just continues going, says the test passed. https://github.com/SuffolkLITLab/ALKiln/blame/v5/lib/scope.js#L2325-L2340I've already been sitting on this PR for like a month, it's affecting all of our interviews (when there are failures), so I think it should get merged, even though I can't figure out testing or really fixing the core issue (error handling).
Any manual testing I have done to ensure my PR is working
Made an example interview and test to manually go through to ensure this is working.