Conversation
Codifies eth.zig's architecture (10-layer dependency hierarchy), naming conventions, comptime discipline, memory management, crypto safety patterns, and known LLVM aarch64 traps so that contributors and AI assistants produce idiomatic, high-quality Zig code.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CLAUDE.md (1)
21-51: Add language specifier to fenced code block.The architecture diagram is in a fenced code block without a language specifier. Add ```text to improve rendering and satisfy linters.
📝 Proposed fix
-``` +```text Layer 1: Primitives (zero deps, no allocator needed) primitives.zig, uint256.zig, hex.zig🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CLAUDE.md` around lines 21 - 51, Change the fenced code block that begins with "Layer 1: Primitives (zero deps, no allocator needed)" to include a language specifier by replacing the opening ``` with ```text so the architecture diagram renders as plain text and satisfies linters; the change should be made around the triple-backtick block containing the Layer 1..Layer 10 diagram.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CLAUDE.md`:
- Line 15: The line "Do NOT use Zig 0.16.0-dev (breaks std.Thread.Mutex)" is
misleading—update that sentence to clarify that the problem is not a stdlib bug
but unsafe user code patterns: change it to state that Zig 0.16.x may trigger
runtime safety checks when user code copies or moves structs containing
std.Thread.Mutex (e.g., storing mutex-containing values without stable
addresses), and recommend using Zig >= 0.15.2 or ensuring mutex-containing types
are not copied/moved (use pointers or arena allocation) instead of claiming the
stdlib is broken.
---
Nitpick comments:
In `@CLAUDE.md`:
- Around line 21-51: Change the fenced code block that begins with "Layer 1:
Primitives (zero deps, no allocator needed)" to include a language specifier
by replacing the opening ``` with ```text so the architecture diagram renders as
plain text and satisfies linters; the change should be made around the
triple-backtick block containing the Layer 1..Layer 10 diagram.
- Clarify Zig 0.16.0-dev Mutex issue is a runtime safety check on struct copy/move, not a stdlib bug - Add `text` language specifier to architecture diagram code block
Summary
CLAUDE.mdencoding eth.zig's coding standards: 10-layer architecture, naming conventions, comptime discipline, memory management, error handling, testing, performance, crypto safety@intFromFloat/@floatFromIntwith u256, u512 division) with workaroundsTest plan
make cipasses (build + fmt + test)Summary by CodeRabbit