Improve amm example: added detailed comments and step-by-step explanation#1112
Open
otaviovin wants to merge 1 commit into
Open
Improve amm example: added detailed comments and step-by-step explanation#1112otaviovin wants to merge 1 commit into
otaviovin wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 264 264
Lines 15292 15292
=======================================
Hits 14990 14990
Misses 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the examples/amm.py script to be more beginner-friendly by adding:
Clear English comments explaining each step
Installation instructions (pip install stellar-sdk)
Example usage and expected output
Minor code clarifications and error handling tips
These changes aim to help new developers quickly understand how to generate and inspect Stellar accounts using the Python SDK.