Fix deployment issues, add validation tests, and rebuild - #201
Merged
Conversation
Goldbarn
self-requested a review
April 27, 2026 22:11
Goldbarn
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilds the game after syncing with main and includes all active deployment fixes. Also adds automated tests to catch deployment regressions.
Changes:
docs/ — Rebuilt with latest changes from main, includes all HiDPI and autoplay fixes
src/render.py — Updated credits to reflect deployment role
src/test_cases/test_deployment.py — 6 new automated deployment validation tests:
No sys.exit() calls in game code (crashes WebAssembly runtime)
No illegal from asyncio import X statements in source files (conflicts with pygbag's event loop)
All sound loads use resolve_asset_path() (bare paths fail on server)
Built docs/index.html contains the HiDPI canvas fix (fixCanvas)
Built docs/index.html does not contain the broken pythonrc.py prefetch
Built docs/index.html does not contain width: 100% canvas sizing
These tests will automatically flag issues like the from asyncio import events bug from PR #194 before they get merged rather than being discovered after deployment.