Repository navigation
chore: move to start-sdk 3.0.3; 1.162.0:0 → 1.162.0:1 - #97
Merged
Merged
Conversation
- pin @start9labs/start-sdk 3.0.3 with a fresh lock; drop the toolchain devDependencies and scripts the SDK now supplies; .prettierrc names the SDK's shared config - file models use z.looseObject, so keys the package doesn't model survive every write to homeserver.yaml, store.json and appservice registrations - declare Coturn in a Dependencies builder as an optional running dependency enabled by the TURN toggle; drop the manifest field and setupDependencies - move pg_restore's unbounded timeout into the exec options - Set Admin Password confirms only when it replaces an existing password, tracked by store.json adminPasswordSet (an import counts as set) - Set Server Address/URL and Delete Appservice preselect nothing - Set Server Address/URL refuses a different name once one is set; init/watchServerName raises its critical task while the name is unset or its domain is missing from the Homeserver interface, and clears it otherwise - fixed-option selects and unions list each option in their description; rewrite caption-only and garbled descriptions; drop dead i18n keys - release notes keep 1.162.0:0's notes above this revision's bullets - sync workflows with the package template (ready_for_review, pr-retarget.yml); resync AGENTS.md and trim its repo section Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
helix-a
approved these changes
Oct 8, 2026
helix-a
left a comment
Member
There was a problem hiding this comment.
Reviewed the SDK 3.0.3 migration, dependency declaration, loose file-model schemas, exec timeout options, server-identity watcher and confirmation changes. No correctness regressions found. Merge-tree is clean and the SDK pin matches npm latest.
Reused successful CI run 37534308101 at 0d9d1d7: type-checking, formatting, bundling and both architecture package builds passed. Runtime testing was not repeated.
Helix-Harness: pi
Helix-Model: openai-codex/gpt-6.1-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK 3.0.3 migration, plus the confirmation and description fixes that ride along with it.
npm audit0). The toolchain the SDK now supplies is dropped, and.prettierrcnames the SDK's shared config.z.looseObject.homeserver.yamlis Synapse's own file and carries keys this package doesn't model. Under SDK 3 az.objectshape would delete every one of them on the nextmerge(), whichmainruns on every start.setupDependenciesinto ansdk.Dependenciesbuilder asoptional,runningand without health checks, enabled by the Config action's Voice and Video Calls toggle. That is the same conditional requirement as before, now published in the manifest.pg_restore's unbounded timeout moves into the exec options; the positional argument is gone in SDK 3.setupPrimaryUrl, because it is baked into every user ID. Its picker now starts empty (default: null), so the permanent name is always chosen deliberately rather than taken from whichever domain is listed first.init/watchServerName.tsraises the critical task while the name is unset or its domain is missing from the Homeserver interface, naming the domain to add back, and clears it otherwise. Box-verified: update from:0keeps running; removing the domain stops Synapse with the task; re-adding it clears the task.store.json'sadminPasswordSettracks this: an import counts as set, and an existing install (no key) still confirms.1.162.0:0's notes above this revision's bullets.ready_for_review,pr-retarget.yml).AGENTS.mdresynced and its repo section trimmed to four rules. The README is updated for the confirmation change, the empty server-name picker and the import model's strictness.🤖 Generated with Claude Code