fix(start-wrt): keep a rule's router-port override across an edit - #3889
Open
Dominion5254 wants to merge 1 commit into
Open
fix(start-wrt): keep a rule's router-port override across an edit#3889Dominion5254 wants to merge 1 commit into
Dominion5254 wants to merge 1 commit into
Conversation
The confirmation for publishing a port already in use on the WAN is persisted per rule, and the list round-trips it. The edit dialog built its result from the form fields alone, so every edit — a label change included — sent the rule with the flag cleared, the backend reported the collision again, and the user was asked again. Carry the flag over, but only while the rule still publishes what was confirmed: the override is a blanket per-rule bypass, so repointing a confirmed rule at a different external range or changing its protocol must re-validate rather than inherit a confirmation the user never gave for those ports. Claude-Session: https://claude.ai/code/session_01QzRghGUbYU542mkwFQUcv9
Dominion5254
force-pushed
the
wrt/edit-keeps-router-port-override
branch
from
September 3, 2026 16:13
58d3b9f to
5872938
Compare
waterplea
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The confirmation for publishing a port the router answers on itself is persisted per rule, and the list round-trips it. The edit dialog built its result from the form fields alone, so every edit — a label change included — sent the rule with the flag cleared, the backend reported the collision again, and the user was asked again.
Carry the flag over, but only while the rule still publishes what was confirmed: the override is a blanket per-rule bypass, so repointing a confirmed rule at a different external range or changing its protocol must re-validate rather than inherit a confirmation the user never gave for those ports.
Claude-Session: https://claude.ai/code/session_01QzRghGUbYU542mkwFQUcv9