Repository navigation
[feat] 층별 학생 출석 일괄 조회 API - #271
Merged
Merged
Conversation
Fresh-Banana
requested review from
Ims2oha,
kimseongchan0914 and
minwoo-3
as code owners
October 30, 2026 04:22
minwoo-3
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 작업 내용
관리자 전개도에서 학생 이름·출석 여부를 보려고 호실마다 명단을 요청하던 흐름을 층 전체 한 번의 요청으로 지원합니다.
GET /api/v1/room/floor/students?floor=3&purpose=DORMITORY추가(기본 용도DORMITORY).{ floor, purpose, rooms: [{ dormitoryRoom, students }] }로 반환하며 학생 항목은 기존/room/attendance와 같은student_id,student_name,student_class,student_number,attended입니다.🔍 리뷰 시 참고사항
/room/floor집계 응답의 호환성을 유지하기 위해 별도 엔드포인트를 선택했습니다.AdminVerifier로 관리자 권한을 먼저 확인합니다. 학생 조회는 403ADMIN_ONLY, 비로그인은 401입니다.student_id는 내부 DB id가 아닙니다../gradlew.bat build --console=plain통과: 680 통과, 실패 0, 기존 실서버 AI·부하 테스트 2개 비활성(총 682개). PostgreSQL 17·Redis 7을 별도 로컬 Compose 프로젝트로 실행했습니다.JAVA_TOOL_OPTIONS=-XX:TieredStopAtLevel=1을 사용했습니다. 서버·CI JVM 설정은 변경하지 않았습니다.npm run harness:check20개 및 OpenAPI YAML 파싱·내부 참조 검사 통과. 브라우저 E2E·실제 학교 API·운영 배포는 미검증입니다.✅ 체크리스트
.env.example등) 변경이 필요한 경우 작성 또는 수정했나요?📎 관련 이슈