Repository navigation
feat: improve connection animation, audio auto-connect, battery detection, and tray exit - #262
Open
aaroncheungzy wants to merge 3 commits into
Open
aaroncheungzy wants to merge 3 commits into
aaroncheungzy wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve four parts of the Windows connection experience: connection animation and feedback, automatic connection on audio playback, battery detection, and the tray Quit button. This replaces the closed, unmerged #261 and includes the subsequent battery and charging-state fixes confirmed by the user. It also carries forward the tray feedback work from #253.
1. Connection animation and feedback
2. Automatic connection on audio playback
The new
audio_auto_connect_enabledconfiguration key defaults tofalse.3. Battery detection and source filtering
Source selection remains a heuristic: unauthenticated advertisements alone cannot establish which physical pair owns a broadcast. Capture fixtures include decoded readings, flags, timing, and signal strength, with no Bluetooth addresses or encrypted payloads. The fixtures replay packet order; a separate timed regression covers expiry.
4. Tray Quit button
QCoreApplication::exit(0)on the GUI thread, preserving normal destruction and worker cleanup.No new dependencies are introduced.
Validation
RelWithDebInfobuild passed with Qt 6.8.3 and MSVC Build Tools.git diff --checkpassed.Screenshots
Screenshots captured by the local UI tests: