Fixed Copy/Paste giving extra multiuse#854
Open
paulkent-coder wants to merge 1 commit intoSpectralPack:mainfrom
Open
Fixed Copy/Paste giving extra multiuse#854paulkent-coder wants to merge 1 commit intoSpectralPack:mainfrom
paulkent-coder wants to merge 1 commit intoSpectralPack:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three code cards (Class, Exploit, and Variable) summon a UI to give the player a choice on how to apply them. These code cards do not spend a Multiuse charge until after the player's choice is confirmed. To implement this, and to make sure the code card doesn't get consumed until confirmation even if it's on its last charge, the game temporarily grants +1 charge to the consumable in use, then deducts that charge again after confirmation.
However, the Copy/Paste joker, which creates a copy of a used code card, doesn't account for this mechanic, which causes it to function incorrectly for those consumables. Copy/Paste triggers after the consumable is given +1 charge but before that charge is taken away again. The end result is that when Copy/Paste creates Class, Exploit, or Variable, the created card has one more Multiuse than it's supposed to.
This PR adds a check to Copy/Paste to detect this situation and deduct one Multiuse from the created card to correct for this phenomenon.