Skip to content

feat: Collect dMSA patch prerequisites from domain controllers #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adilalperenciftci wants to merge 3 commits into
base: 2.X
Choose a base branch
from
Open

feat: Collect dMSA patch prerequisites from domain controllers #235

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51c2592
feat: Collect dMSA patch prerequisites from domain controllers
adilalperenciftci Oct 25, 2026
846e431
fix: await domain controller post-processing
adilalperenciftci Oct 27, 2026
4325585
feat: emit delegated managed service accounts
adilalperenciftci Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Runtime/ObjectProcessors.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ await _containerProcessor.GetContainingObject(dn) is (true, var container)) {
}

if (resolvedSearchResult.IsDomainController)
ProcessDomainController(resolvedSearchResult, ret, apiName);
await ProcessDomainController(resolvedSearchResult, ret, apiName);

var trimmedSamAccountName = samAccountName?.TrimEnd('$');

Expand Down Expand Up @@ -453,7 +453,7 @@ private RegistryProcessor GetRegistryProcessor(ResolvedSearchResult resolvedSear
})).Value;
}

private async void ProcessDomainController(ResolvedSearchResult resolvedSearchResult, Computer ret,
private async Task ProcessDomainController(ResolvedSearchResult resolvedSearchResult, Computer ret,
string apiName) {
_log.LogDebug("Processing DC: {dc}", apiName);

Expand All @@ -464,7 +464,9 @@ private async void ProcessDomainController(ResolvedSearchResult resolvedSearchRe
StrongCertificateBindingEnforcement =
_dcRegistryProcessor.GetStrongCertificateBindingEnforcement(apiName),
VulnerableNetlogonSecurityDescriptor =
_dcRegistryProcessor.GetVulnerableNetlogonSecurityDescriptor(apiName)
_dcRegistryProcessor.GetVulnerableNetlogonSecurityDescriptor(apiName),
CurrentBuildNumber = _dcRegistryProcessor.GetCurrentBuildNumber(apiName),
CurrentBuildRevision = _dcRegistryProcessor.GetCurrentBuildRevision(apiName)
};

ret.DCRegistryData = dCRegistryData;
Expand Down
Loading