SPACEDF-21727: [SpaceDF] - [BE] Add APIDevice model for non-LoRa devices - #150
Open
ngovinh2k2 wants to merge 5 commits into
Open
SPACEDF-21727: [SpaceDF] - [BE] Add APIDevice model for non-LoRa devices#150ngovinh2k2 wants to merge 5 commits into
ngovinh2k2 wants to merge 5 commits into
Conversation
|
Linked Redmine issue: https://redmine.digitalfortress.dev/issues/21727 |
Comment on lines
+223
to
+226
| for handler in handlers: | ||
| handler.create(device, nested_data.get(handler.relation)) | ||
| if nested_data.get(handler.relation): | ||
| logger.info(f"{handler.label} created for device {device.id}") |
Member
There was a problem hiding this comment.
i think we can improve by not getting handlers list
| handlers = get_nested_device_handlers() | ||
| device_objs = [] | ||
| lorawan_objs = [] | ||
| nested_objs = {relation: [] for relation in handlers} |
Member
There was a problem hiding this comment.
nested_objs. rename for better readability too anh. something like e.g. related_objs_by_relation, ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add APIDevice model for non-LoRa devices
Why?
How?
Testing?
Anything Else?