Repository navigation
CLI-1470 Prepare reusable SQAA requests before execution - #1242
tomshafir-sonarsource wants to merge 2 commits into
Conversation
✅ Deploy Preview for sonarqube-cli canceled.
|
Code Review ✅ Approved🟡 Medium risk · Separating SQAA request preparation from execution snapshots file contents earlier, so analysis may use stale inputs if files change before execution. Separates SQAA request preparation from execution so each destination and payload can be fingerprinted and analyzed as-is, preserving project grouping, validation, 503 retries, and 413 splitting without rereading files. No issues found. Verification Rules 2/2 met PRs 2 inspectedFunctional validation No results Rules 2 passed 2 not applicable
Broader impact PRs 2 inspectedCross-PR 2 PRs inspected 0 open impacts
Auto-approval Withheld For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|




Separate SQAA request preparation from execution so callers can fingerprint each destination and payload, then analyze those exact inputs. Preserve project grouping, validation, 503 retries, and oversized-request splitting without rereading files during execution.
Remove the obsolete combined entry points and migrate their tests to explicit preparation and execution.
Validation:
Local validation limits: the full unit run has one Java fixture failure, and combined secrets/SQAA integration cases stop before SQAA because the Java secrets scanner cannot establish a loopback connection. The repository DEEP analysis check fails with ECONNREFUSED.