Skip to content

CLI-1470 Prepare reusable SQAA requests before execution - #1242

Open
tomshafir-sonarsource wants to merge 2 commits into
masterfrom
task/ts/CLI-1470-prepare-reusable-sqaa-requests
Open

tomshafir-sonarsource wants to merge 2 commits into
masterfrom
task/ts/CLI-1470-prepare-reusable-sqaa-requests

Conversation

@tomshafir-sonarsource

Copy link
Copy Markdown
Contributor

Separate SQAA request preparation from execution so callers can fingerprint each destination and payload, then analyze those exact inputs. Preserve project grouping, validation, 503 retries, and oversized-request splitting without rereading files during execution.

Remove the obsolete combined entry points and migrate their tests to explicit preparation and execution.

Validation:

  • Type checking, Prettier, and ESLint pass.
  • All 45 analyze unit spec files and both selected hook integration spec files pass.
  • Installed CLI checks pass for single-file DEEP analysis, 503 retries, 413 splitting, and invalid inputs in isolated projects.
  • Mutation testing confirms the snapshot regression test catches incorrect 413 split contents.

Local validation limits: the full unit run has one Java fixture failure, and combined secrets/SQAA integration cases stop before SQAA because the Java secrets scanner cannot establish a loopback connection. The repository DEEP analysis check fails with ECONNREFUSED.

@netlify

netlify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for sonarqube-cli canceled.

Name Link
🔨 Latest commit a80d696
🔍 Latest deploy log https://app.netlify.com/projects/sonarqube-cli/deploys/6af32694382359abb24cc2c2

@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

CLI-1470

@tomshafir-sonarsource
tomshafir-sonarsource removed the request for review from tsiaraskon-sonar November 10, 2026 14:15
@gitar-bot

gitar-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · Separating SQAA request preparation from execution snapshots file contents earlier, so analysis may use stale inputs if files change before execution.

Separates SQAA request preparation from execution so each destination and payload can be fingerprinted and analyzed as-is, preserving project grouping, validation, 503 retries, and 413 splitting without rereading files. No issues found.

Verification Rules 2/2 met PRs 2 inspected

Functional validation No results

Rules 2 passed 2 not applicable

✅ Internal artifact registries
✅ Repository license compliance

Broader impact PRs 2 inspected
Cross-PR 2 PRs inspected 0 open impacts

PR 1191: Remove sequential awaits in loops and split oversized architecture files Inspected
PR 1228: CLI-1345 Record one telemetry event per target project Inspected

Auto-approval Withheld

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3 New issues

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant