Skip to content

CLI-1521 CLI: Gate Architecture commands in SQS for 2026.6 onwards - #1239

Merged
madalin-antonoiu-sonarsource merged 6 commits into
masterfrom
codex/sqs-architecture-version-gate
Nov 10, 2026
Merged

madalin-antonoiu-sonarsource merged 6 commits into
masterfrom
codex/sqs-architecture-version-gate

Conversation

@madalin-antonoiu-sonarsource

@madalin-antonoiu-sonarsource madalin-antonoiu-sonarsource commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Architecture commands currently reach public endpoints that are absent from older SonarQube Server releases. Check the Server version before resolving a project and show the minimum supported version when it is too old. Cloud is unchanged, and Community Build is excluded because it does not include Architecture; if the version cannot be read, retain the existing API compatibility handling.

The proposed minimum is 2026.6, pending confirmation that the required public APIs ship in that release.

Validation: 104 Architecture unit tests, 504 integration tests plus the unknown-version case, typecheck and lint. Checked SQS 2026.5.4 locally, Jonathan's 2026.6-SNAPSHOT build, and read-only Cloud operations.

@netlify

netlify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for sonarqube-cli canceled.

Name Link
🔨 Latest commit 7747dde
🔍 Latest deploy log https://app.netlify.com/projects/sonarqube-cli/deploys/6af312b75ef52a09a6605de7

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title CLI: Gate Architecture commands by SQS version CLI-1521 CLI: Gate Architecture commands by SQS version Nov 10, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

CLI-1521

@madalin-antonoiu-sonarsource
madalin-antonoiu-sonarsource marked this pull request as ready for review November 10, 2026 11:53

@tomshafir-sonarsource tomshafir-sonarsource left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved with one small comment on the unneeded Cloud test setup.

@gitar-bot

gitar-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 closed / 1 findings

🟡 Medium risk · Gating Server Architecture commands at 2026.6 could unnecessarily deny access on installations that expose the required APIs below that threshold.

Gates Architecture commands on SonarQube Server version, requiring 2026.6 or later before resolving a project, with Cloud unchanged and Community Build excluded. A finding that the Community Build rejection message suggested an upgrade that could not help was resolved, so the message no longer points to an impossible fix. No open issues found.

✅ 1 closed
✅ Quality: Community Build rejection says upgrade to 2026.6, which can't help

📄 src/commands/architecture/_common/project.ts:37-45 📄 tests/integration/specs/architecture/architecture-version.test.ts:25 📄 tests/integration/specs/architecture/architecture-version.test.ts:49
After this commit, a Community Build version such as 26.11 is rejected through !isFullYearVersion(version), but it still gets the version-too-old error: "SonarQube Server 26.11 does not support these Architecture commands; 2026.6 or later is required." with the hint "Upgrade SonarQube Server, then retry." That is misleading. 26.11 is numerically newer than 2026.6, and no Community Build upgrade adds Architecture, since the PR says it is excluded because it lacks the feature. The new 26.11 test case checks for '2026.6 or later is required', so the tests now expect this misleading text. Fix: give the Community Build case its own error, e.g. "Architecture commands are not available in SonarQube Community Build; SonarQube Server 2026.6 or later is required", with a matching hint, and update the test.

Verification Rules 2/2 met PRs 2 inspected

Functional validation No results

Rules 2 passed 2 not applicable

✅ Internal artifact registries
✅ Repository license compliance

Broader impact PRs 2 inspected
Cross-PR 2 PRs inspected 0 open impacts

PR 716: MCP-733 Prerequisite: Gate Architecture tools by SQS version Inspected
PR 1217: SONARCH-3492 CLI: Report and respect a file-managed intended architecture Inspected

Auto-approval Withheld

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud

Copy link
Copy Markdown

@madalin-antonoiu-sonarsource
madalin-antonoiu-sonarsource merged commit e0a691e into master Nov 10, 2026
27 checks passed
@madalin-antonoiu-sonarsource
madalin-antonoiu-sonarsource deleted the codex/sqs-architecture-version-gate branch November 10, 2026 12:59
@madalin-antonoiu-sonarsource madalin-antonoiu-sonarsource changed the title CLI-1521 CLI: Gate Architecture commands by SQS version CLI-1521 CLI: Gate Architecture commands for SQS for 2026.6 onwards Nov 10, 2026
@madalin-antonoiu-sonarsource madalin-antonoiu-sonarsource changed the title CLI-1521 CLI: Gate Architecture commands for SQS for 2026.6 onwards CLI-1521 CLI: Gate Architecture commands in SQS for 2026.6 onwards Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants