Repository navigation
Conversation
d733b01 to
63c0daf
Compare
63c0daf to
345ec76
Compare
345ec76 to
c0de48a
Compare
Code Review ✅ Approved 1 closed / 1 findings🟡 Medium risk · Routing internal CI NuGet restores through production Edge with fresh private-reader credentials could disrupt builds if source selection or credential pairing is wrong. Routes internal Windows and Linux NuGet restores through ✅ 1 closed✅ Edge Case: Rollback variable only honours exact lowercase
|
| Auto-apply | Compact |
|
|
Was this helpful? React with 👍 / 👎 | Gitar
|
|
[From Codex] The registry-host verification refers to the previous internal hostname. This PR deliberately adopts Current-revision Windows/Linux proof passed all 22 assertions: https://github.com/SonarSource/sonar-scanner-msbuild/actions/runs/41119736701 . Authenticated private metadata and complete signed private-package downloads reached production Edge with its native private reader; SaaS rollback, all 77 lockfiles and unrelated Artifactory values were preserved. The PR description now records this reviewed hostname migration and Datadog request correlation. The former-host recommendation is therefore not applied. |
pavel-mikula-sonarsource
left a comment
There was a problem hiding this comment.
The action looks like a candidate for reusable extraction
| @@ -0,0 +1,85 @@ | |||
| name: Configure NuGet | |||
There was a problem hiding this comment.
How much of this is reusable by the other 10 repos using NuGet? This looks like something that should live in one of the public tooling repos and be reused, instead of copied 10 times.
|
Superseded by #3537, which does the complete migration to |



BUILD-13211: Route internal/Warp Windows and Linux NuGet restores through
https://repox.sonar.buildwith a fresh matching native private reader, using the sharedconfig-nugetaction pinned tob4eede988476ebb13a242fbc3ae4e8e374d78ad0. Hosted/macOS jobs keep SaaS access; local development keeps the committed SaaS configuration.NuGetPackageSourceCredentials_Repox, compatible with Visual Studio 2017’s NuGet client. Keep existing Maven, Orchestrator, publication, signing and promotion credentials.Repoxsource before solution, tool, unit-test and integration-test download phases. Preserve required signatures, trusted signers, versions and lock hashes.NUGET_USE_PROD_EDGE=false, including Edge-to-SaaS calls in the same job. Normalize case/outer whitespace and reject invalid inherited values before Vault access.Test plan and results for
c0de48ab:repox.sonar.build; repeat with separate SaaS caches/readers in the same job. All four legs preserve 77 lockfiles and all six generic Artifactory values. All 22 proof assertions pass: https://github.com/SonarSource/sonar-scanner-msbuild/actions/runs/41119736701264f1910956526a34abad6f6596ac4abcba79035636d77fd6d4db179e9a3a13f.Infrastructure dependency merged: https://github.com/SonarSource/sonarsource-infra-k8s/pull/186 . Temporary download-validation workflow/scripts stay outside this PR. Client caches are emptied for proof; production server caches remain enabled. Release-only NuGet signing/public publication are preserved and are not invoked. Post-merge bandwidth impact remains to be measured after adoption. This PR remains draft.
The explicit hostname overrides the shared action’s older
repox-internal.sonar.builddefault. The merged infrastructure change publishesrepox.sonar.buildthrough split-horizon DNS: runner VPCs reach the production Edge’s internal ALB with the matching certificate. This is the reviewed hostname migration requested for this PR, supported by the authenticated Windows/Linux proof above.2026-10-30T20:00:42.524Z, traceec392566f93f2fa14ddea170aebe0512; 373 correlated root package downloads. Private requests, root restores.2026-10-30T20:00:55.419Z, trace93a4469c08bb52a6c0e75cd923c075e1; 367 correlated root package downloads. Private requests, root restores.