Skip to content

ACOMMONS-164 Improve IP classification and allow querying without reparsing #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lijun-chen-sonarsource merged 16 commits into from
Oct 22, 2026
Merged

ACOMMONS-164 Improve IP classification and allow querying without reparsing #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f6b4bca
ACOMMONS-164 Expose parsed IP addresses and classification predicates
lijun-chen-sonarsource Oct 14, 2026
e34c9c9
ACOMMONS-164 Use guarded JDK parsing for numeric IP literals
lijun-chen-sonarsource Oct 14, 2026
d8963f9
ACOMMONS-164 Classify mapped and translated IPv6 ranges by their IPv4…
lijun-chen-sonarsource Oct 14, 2026
8d9048e
ACOMMONS-164 Ignore IPv6 zone suffixes during classification
lijun-chen-sonarsource Oct 14, 2026
a60b28c
ACOMMONS-164 Recognize IPv4 and IPv6 multicast ranges
lijun-chen-sonarsource Oct 14, 2026
b2d76c1
ACOMMONS-164 Expose the shared S1313 exemption policy
lijun-chen-sonarsource Oct 14, 2026
ec34bdd
test: clarify IPv4-mapped RFC 1918 private addresses in tests
lijun-chen-sonarsource Oct 19, 2026
333debb
Apply suggestion
lijun-chen-sonarsource Oct 19, 2026
24207de
test: group IPs in shouldDetectDocumentation
lijun-chen-sonarsource Oct 19, 2026
66a1864
test: apply zone-suffix comment suggestion
lijun-chen-sonarsource Oct 19, 2026
39aae00
refactor: don't use unclear "IPv4 payload" terminology. Use "embedded…
lijun-chen-sonarsource Oct 19, 2026
7823d72
perf: Use precompiled regex
lijun-chen-sonarsource Oct 19, 2026
00c728b
test: add more tests for shouldDetectAnyAddress
lijun-chen-sonarsource Oct 19, 2026
4705f25
Rename `isS1313Exempt` to `isAllowedToBeHardcoded` and add tests
lijun-chen-sonarsource Oct 20, 2026
5795bb2
docs: add IpAddressClassifier to README.md
lijun-chen-sonarsource Oct 20, 2026
42337cb
Remove multicast exemption from isAllowedToBeHardcoded
lijun-chen-sonarsource Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions commons/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Logic useful for an average language plugin
* [`ExternalReportProvider`](./src/main/java/org/sonarsource/analyzer/commons/ExternalReportProvider.java) - to get the list of io.File with external reports
* [`ProgressReport`](./src/main/java/org/sonarsource/analyzer/commons/ProgressReport.java) - to produce logs with number of analyzed files
* [`FileProvider`](./src/main/java/org/sonarsource/analyzer/commons/FileProvider.java) - to get files matching given pattern in the given directory
* [`IpAddressClassifier`](./src/main/java/org/sonarsource/analyzer/commons/appsec/IpAddressClassifier.java) - to parse numeric IP addresses and CIDRs and query their classification

### License
Copyright 2009-2023 SonarSource.
Expand Down
Loading