Conversation
Updated Node.js version from 22 to 20 for compatibility.
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Node.js version used by the npm publishing job in the CI workflow, likely to improve compatibility when publishing to npm.
Changes:
- Downgrade the
npm-publish-latestjob’sactions/setup-nodeversion from Node 22 to Node 20.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
71
to
74
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: 22 | ||
| node-version: 20 # for npm@latest | ||
| registry-url: 'https://registry.npmjs.org' |
There was a problem hiding this comment.
The PR description says Node.js was updated from 22 to 20 for compatibility, but this change only affects the npm-publish-latest job; the build matrix still runs on 22 and 24 and npm-publish-dev still passes node_version: 22. Please either update the PR description to reflect the narrower scope, or align the other workflow Node versions if the intent is to downgrade CI more broadly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Node.js version from 22 to 20 for compatibility.