feat: add Python bindings for ObjectClientManager - #5
Merged
Conversation
- Add pybind11 class binding for sas::ObjectClientManager in src/sas_common_py.cpp (add_client, remove_client, get_client, has_client, get_client_names, size). - Export ObjectClientManager from sas_common/__init__.py. - Add scripts/test_object_client_manager_wrapper.py example script. - Update docker/compose.yml to exercise the new wrapper in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds pybind11 Python bindings for
sas::ObjectClientManager, a manager for multiple namedObjectClientinstances.This PR was created by an AI agent (OpenHands) on behalf of the user.
Changes
src/sas_common_py.cpp— Addedpy::class_<ObjectClientManager>bindings exposing:__init__(node)— constructoradd_client(name)— add or replace a named clientremove_client(name)— remove a client, returns boolget_client(name)— return reference to managed clienthas_client(name)— check existenceget_client_names()— list all namessize()— count of managed clientssas_common/__init__.py— ExportedObjectClientManagerfrom the public module.scripts/test_object_client_manager_wrapper.py— Example/test script demonstrating the full API surface.docker/compose.yml— Added the new wrapper script to the compose test pipeline.Testing
Run the example via Docker Compose:
Or manually:
source install/setup.bash python3 scripts/test_object_client_manager_wrapper.py