Rewrite Custom Syntax#165
Open
UnderscoreTud wants to merge 28 commits into
Open
Conversation
# Conflicts: # build.gradle # src/main/java/com/btk5h/skriptmirror/ParseOrderWorkarounds.java # src/main/java/com/btk5h/skriptmirror/SkriptMirror.java # src/main/java/com/btk5h/skriptmirror/skript/custom/ExprExpression.java # src/main/java/com/btk5h/skriptmirror/skript/custom/ExprParseTags.java # src/main/java/com/btk5h/skriptmirror/skript/custom/ExprRawExpression.java # src/main/java/com/btk5h/skriptmirror/skript/reflect/ExprJavaCall.java # src/main/java/org/skriptlang/reflect/syntax/custom/event/EventValuesEntryData.java # src/main/java/org/skriptlang/reflect/syntax/custom/expression/ChangerEntryData.java # src/main/java/org/skriptlang/reflect/syntax/event/elements/CustomEvent.java # src/main/java/org/skriptlang/reflect/syntax/event/elements/EffCallEvent.java # src/main/java/org/skriptlang/reflect/syntax/event/elements/ExprCustomEvent.java # src/main/java/org/skriptlang/reflect/syntax/event/elements/ExprCustomEventValue.java # src/main/java/org/skriptlang/reflect/syntax/event/elements/ExprEventData.java # src/main/java/org/skriptlang/reflect/syntax/event/elements/ExprReplacedEventValue.java # src/main/java/org/skriptlang/reflect/syntax/event/elements/StructCustomEvent.java # src/main/java/org/skriptlang/reflect/syntax/expression/elements/ExprChangeValue.java # src/main/java/org/skriptlang/reflect/syntax/expression/elements/StructCustomExpression.java
…r than the ParserInstance
sovdeeth
requested changes
Feb 7, 2026
Member
sovdeeth
left a comment
sovdeeth
left a comment
There was a problem hiding this comment.
I haven't looked through super closely but this seems fantastic from skimming it
No glaring issues (except the lack of docs annotations!)
origins and priorities should probably be handled automatically for the most part (may want to use an origin-applying registry)
The logic for the custom events looks great, good usage of ERS
# Conflicts: # build.gradle
…ed custom event classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current custom syntax implementation is built on very old Skript API, when modifying syntax registries at runtime wasn't natively supported. This led to code relying on hacky methods and workarounds to achieve this type of behavior, as a byproduct, the codebase for this system was extremely hard to follow, fragmented and difficult to maintain.
Solution
Rewrite the custom syntax system from the ground up to use the registration API, significantly improving its readability, maintainability and consistency.
Testing Completed
Manual testing
Supporting Information
This rewrite should not introduce any user-facing breaking changes
Review Notice
If you are reviewing this pull request, I suggest starting from the
org.skriptlang.reflect.syntax.custom.sharedpackage, as everything is built on top of the base classes found there.Completes: none
Related: none
AI assistance: none