Updates for worldborders by AnOwlBe · Pull Request #8659 · SkriptLang/Skript

AnOwlBe · 2026-05-25T08:43:32Z

Problem

All worldborder elements were running on deprecated registration methods as well as worldborder events being in the god awful simpleevents while also using deprecated registration methods
additionally worldborderwarningtime was using deprecated methods to set/get duration (old method used seconds via long newer method simply uses ticks)

Solution

Deletes all worldborder elements including events
Creates a worldbordermodule
Re adds all worldborder elements including events to use new registry & event-value registry system
Makes versions >= 1.21.11 use the newer method for get/setting warningtime for worldborders older versions fallback to the older method
Changes to tests:
changed test for warningtime when using >= 1.21.11
changed all worldborder tests to use 'catch runtime errors' when getting/setting/removing NaN/infinity/-infinity

Testing Completed

Manual testing completed everything works (though additional testing should be done on lower versions as I only tested on 1.21.11)

Supporting Information

I think registering all the worldborder events & event-values should each be their old file inside elements -> events though I would like confirmation on this before doing (right now its all registered in worldbordermodule)

Completes: none
Related: replaces #8504
AI assistance: next to none

overall this is mostly an internal PR nothing for the user really changes (for the most part there are some things)

…rldBorder

…s/expressions/ExprWorldBorderWarningTime.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>

…s/expressions/ExprWorldBorder.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>

…s/WorldBorderModule.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>

…viously

…rldBorder

… add/set/remove NaN/infinity/-infinity

APickledWalrus

Looking good so far. Indentation is cooked for a lot of the register methods - I covered some but there are more, so I recommend going back through those files.

…s/expressions/ExprSecCreateWorldBorder.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

…s/WorldBorderModule.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

…s/expressions/ExprWorldBorderWarningTime.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

…rldBorder # Conflicts: # src/main/java/org/skriptlang/skript/bukkit/worldborder/elements/WorldBorderModule.java

APickledWalrus

Formatting is still cooked on a bunch of the register methods - specifically the signature lines and closing curly brace lines. Also double check spacing on your methodExists calls - there is missing spacing between parameters throughout those.

AnOwlBe · 2026-05-28T01:37:51Z

god damn why did it revert I did all of those changes ;-;

…s/effects/EffWorldBorderExpand.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

…s/expressions/ExprSecCreateWorldBorder.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

…s/expressions/ExprWorldBorder.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

…s/expressions/ExprWorldBorderSize.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

…s/expressions/ExprWorldBorder.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

…rldBorder

AnOwlBe · 2026-05-28T01:50:10Z

Okay I think I fixed everything @APickledWalrus ^

sovdeeth

looks good, just some weird formatting issues

sovdeeth · 2026-05-28T05:21:03Z

+			infoBuilder(ExprWorldBorderCenter.class, Location.class, "world[ ]border (center|middle)", "worldborders", true)
+				.supplier(ExprWorldBorderCenter::new)
+				.build());
+		}


sovdeeth · 2026-05-28T05:21:22Z

-	static {
-		registerDefault(ExprWorldBorderDamageAmount.class, Double.class, "world[ ]border damage amount", "worldborders");
-	}
+     public static void register(SyntaxRegistry syntaxRegistry) {


…s/expressions/ExprWorldBorderDamageBuffer.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

…s/expressions/ExprWorldBorderDamageAmount.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

…s/expressions/ExprWorldBorderWarningTime.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

…rldBorder

AnOwlBe · 2026-05-28T05:51:20Z

okay I just ran it through a spaces to tabs converter n pasted it so it should be completely tabs

sovdeeth · 2026-05-28T05:53:40Z

okay I just ran it through a spaces to tabs converter n pasted it so it should be completely tabs

It didn't fix the ones pickle commented on (ExprWorldBorderDamageAmount for example) and there's still a few with the closing } for the register method too far indented.

AnOwlBe · 2026-05-28T05:56:35Z

okay I fixed all extra tab for } for register methods

Absolutionism · 2026-05-28T16:12:17Z

 	private Expression<Number> numberExpr;
 	private @Nullable Expression<Timespan> timespan;
 	private static final double MAX_WORLDBORDER_SIZE = 59999968;
+	private final static boolean useDeprecated = !Skript.methodExists(org.bukkit.WorldBorder.class, "changeSize");


Suggested change

private final static boolean useDeprecated = !Skript.methodExists(org.bukkit.WorldBorder.class, "changeSize");

private static final boolean USE_DEPRECATED = !Skript.methodExists(org.bukkit.WorldBorder.class, "changeSize");

Absolutionism · 2026-05-28T16:15:39Z

+				.build());
 	}

+	private final static boolean useDeprecated = !Skript.methodExists(WorldBorder.class, "getWarningTimeTicks");


Suggested change

private final static boolean useDeprecated = !Skript.methodExists(WorldBorder.class, "getWarningTimeTicks");

private static final boolean USE_DEPRECATED = !Skript.methodExists(WorldBorder.class, "getWarningTimeTicks");

Absolutionism · 2026-05-28T16:17:56Z

+				.build());
 	}

+	private final static boolean useDeprecated = !Skript.methodExists(org.bukkit.WorldBorder.class,"getWarningTimeTicks");


Suggested change

private final static boolean useDeprecated = !Skript.methodExists(org.bukkit.WorldBorder.class,"getWarningTimeTicks");

private static final boolean USE_DEPRECATED = !Skript.methodExists(org.bukkit.WorldBorder.class,"getWarningTimeTicks");

Absolutionism · 2026-05-28T16:19:34Z

+				)
+				.addExample("""
+					on worldborder bounds change:
+					    "broadcast "The diameter of %event-worldborder% is changing from %past event-number% to %event-number% over the next %event-timespan%"


Suggested change

"broadcast "The diameter of %event-worldborder% is changing from %past event-number% to %event-number% over the next %event-timespan%"

broadcast "The diameter of %event-worldborder% is changing from %past event-number% to %event-number% over the next %event-timespan%

Absolutionism · 2026-05-28T16:21:58Z

+				.addDescription("""	
+					Called when a moving world border has finished its move.
+					This event does not get called for virtual borders.
+				"""
+				)


Suggested change

.addDescription("""

Called when a moving world border has finished its move.

This event does not get called for virtual borders.

"""

)

.addDescription("""

Called when a moving world border has finished its move.

This event does not get called for virtual borders.

""")

Absolutionism · 2026-05-28T16:22:08Z

+				.addExample("""
+					on worldborder bounds finish change:
+					    broadcast "Over the past %event-timespan%, the diameter of %event-worldborder% went from %past event-number% to %event-number%"
+				""")


Suggested change

.addExample("""

on worldborder bounds finish change:

broadcast "Over the past %event-timespan%, the diameter of %event-worldborder% went from %past event-number% to %event-number%"

""")

.addExample("""

on worldborder bounds finish change:

broadcast "Over the past %event-timespan%, the diameter of %event-worldborder% went from %past event-number% to %event-number%"

""")

Absolutionism · 2026-05-28T16:22:29Z

+				.addExample("""
+					on worldborder bounds change:
+					    "broadcast "The diameter of %event-worldborder% is changing from %past event-number% to %event-number% over the next %event-timespan%"
+				""")


Suggested change

""")

""")

Absolutionism · 2026-05-28T16:26:23Z

+				"""
+				)


Suggested change

"""

)

""")

Absolutionism · 2026-05-28T16:26:40Z

+				.addExample("""
+					on worldborder center change:
+					    "broadcast "The center of %event-worldborder% has moved from %past event-location% to %event-location%"
+				""")


Suggested change

.addExample("""

on worldborder center change:

"broadcast "The center of %event-worldborder% has moved from %past event-location% to %event-location%"

""")

.addExample("""

on worldborder center change:

broadcast "The center of %event-worldborder% has moved from %past event-location% to %event-location%

""")

All the worldborder stuff

4202f0b

AnOwlBe requested a review from a team as a code owner May 25, 2026 08:43

AnOwlBe requested review from Burbulinis and erenkarakal and removed request for a team May 25, 2026 08:43

skriptlang-automation Bot added needs reviews A PR that needs additional reviews needs triage An issue that hasn't been classified or verified yet labels May 25, 2026

This comment has been minimized.

Sign in to view

AnOwlBe and others added 3 commits May 25, 2026 04:44

Merge branch 'dev/feature' into UpdateWorldBorder

5ea7401

Changes to make all exprs use default (previously was false)

1c70643

Merge remote-tracking branch 'origin/UpdateWorldBorder' into UpdateWo…

13fb0ea

…rldBorder

skriptlang-automation Bot added this to 2.16 Releases May 25, 2026

skriptlang-automation Bot moved this to In Review in 2.16 Releases May 25, 2026

skriptlang-automation Bot added enhancement Feature request, an issue about something that could be improved, or a PR improving something. and removed needs triage An issue that hasn't been classified or verified yet labels May 25, 2026

Efnilite requested changes May 25, 2026

View reviewed changes

AnOwlBe and others added 7 commits May 25, 2026 13:16

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

58d5ac6

…s/expressions/ExprWorldBorderWarningTime.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

49d9e3a

…s/expressions/ExprWorldBorder.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

b61d5d2

…s/WorldBorderModule.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

8df3d97

…s/WorldBorderModule.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

06f426c

…s/WorldBorderModule.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>

Small changes that made tests fail for ExprWorldBorderWarningTime pre…

7ea29b6

…viously

Merge remote-tracking branch 'origin/UpdateWorldBorder' into UpdateWo…

7abb36a

…rldBorder

AnOwlBe requested a review from Efnilite May 25, 2026 17:38

AnOwlBe added 2 commits May 25, 2026 13:39

.

90d6410

Implements 'catch runtime errors' for all tests for worldborders that…

7eb1d0e

… add/set/remove NaN/infinity/-infinity

APickledWalrus requested changes May 27, 2026

View reviewed changes

skriptlang-automation Bot removed the needs reviews A PR that needs additional reviews label May 27, 2026

AnOwlBe and others added 2 commits May 27, 2026 17:29

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

e68bf09

…s/expressions/ExprSecCreateWorldBorder.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

fe72ed5

…s/WorldBorderModule.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

AnOwlBe and others added 6 commits May 27, 2026 17:31

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

3e001e1

…s/expressions/ExprWorldBorderWarningTime.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

92ba5ec

…s/expressions/ExprWorldBorderWarningTime.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

Merge branch 'dev/feature' into UpdateWorldBorder

9617a8b

code

9e305b2

Merge remote-tracking branch 'origin/UpdateWorldBorder' into UpdateWo…

3420820

…rldBorder # Conflicts: # src/main/java/org/skriptlang/skript/bukkit/worldborder/elements/WorldBorderModule.java

ig I put some files in the wrong branch

e4f38cf

AnOwlBe requested a review from APickledWalrus May 27, 2026 22:36

Fixes indention for the register methods of some of the expressions

de5d9b3

APickledWalrus requested changes May 28, 2026

View reviewed changes

AnOwlBe and others added 7 commits May 27, 2026 21:38

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

3d1279e

…s/effects/EffWorldBorderExpand.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

d5328d5

…s/expressions/ExprSecCreateWorldBorder.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

8518d2c

…s/expressions/ExprWorldBorder.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

99aece3

…s/expressions/ExprWorldBorderSize.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

a28b398

…s/expressions/ExprWorldBorder.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>

Fixes tons of small pickle requests

7fee384

Merge remote-tracking branch 'origin/UpdateWorldBorder' into UpdateWo…

4379d38

…rldBorder

AnOwlBe requested a review from APickledWalrus May 28, 2026 02:41

sovdeeth approved these changes May 28, 2026

View reviewed changes

AnOwlBe and others added 5 commits May 28, 2026 01:45

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

46a042e

…s/expressions/ExprWorldBorderDamageBuffer.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

58feb11

…s/expressions/ExprWorldBorderDamageAmount.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

Update src/main/java/org/skriptlang/skript/bukkit/worldborder/element…

79f2c97

…s/expressions/ExprWorldBorderWarningTime.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

(hopefully) fixes all formatting issues

bba6b9e

Merge remote-tracking branch 'origin/UpdateWorldBorder' into UpdateWo…

5f61fe9

…rldBorder

Even MORE formatting fixes

e41ddef

Absolutionism requested changes May 28, 2026

View reviewed changes

	private final static boolean useDeprecated = !Skript.methodExists(org.bukkit.WorldBorder.class, "changeSize");
	private static final boolean USE_DEPRECATED = !Skript.methodExists(org.bukkit.WorldBorder.class, "changeSize");

	"broadcast "The diameter of %event-worldborder% is changing from %past event-number% to %event-number% over the next %event-timespan%"
	broadcast "The diameter of %event-worldborder% is changing from %past event-number% to %event-number% over the next %event-timespan%

Uh oh!

Conversation

AnOwlBe commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Testing Completed

Supporting Information

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

APickledWalrus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

APickledWalrus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AnOwlBe commented May 28, 2026

Uh oh!

AnOwlBe commented May 28, 2026

Uh oh!

sovdeeth left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AnOwlBe commented May 28, 2026

Uh oh!

sovdeeth commented May 28, 2026

Uh oh!

AnOwlBe commented May 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

AnOwlBe commented May 25, 2026 •

edited

Loading