add a text replace expression

[novystar]

Problem

In skript, there is currently only an effect for text replacement, meaning you have to store the value somewhere before doing the replacement which can be inconvenient and takes up more lines.

Solution

This PR adds a replace expression, meaning you can now do in 1 line what used to take 3.

Before:

set {_message} to "Hello [player]"
replace "[player]" in {_message} with {_playerName}
send {_message} to {_player}

After:

send replace "[player]" in "Hello [player]" with {_playerName} to {_player}

Syntaxes (same as the effect):

"replace [(all|every)|first:[the] first] %strings% in %strings% with %string% [case:with case sensitivity]"
"replace [(all|every)|first:[the] first] %strings% with %string% in %strings% [case:with case sensitivity]"
"(replace [with|using] regex|regex replace) %strings% in %strings% with %string%"
"(replace [with|using] regex|regex replace) %strings% with %string% in %strings%"

Testing Completed

src/test/skript/tests/syntaxes/expressions/ExprReplace.sk

Supporting Information

The current syntax being the same as the effect may be a little unintuitive.

I also encountered a ParserInstance related Skript API Exception while trying to add null test cases to my unit test. I am assuming its a bug with the test effect since it behaves as normal in effect commands and scripts.

---

Completes: none
Related: none
AI assistance: none

[Efnilite]

almost there 🙏

[sovdeeth]

looking good

[novystar]

Hey @sovdeeth I'm still waiting for review/approval on this, thanks

[sovdeeth]

Hey @sovdeeth I'm still waiting for review/approval on this, thanks

Thanks for the reminder, will review later tonight

[sovdeeth]

Looks great! Nice work

[novystar]

While testing my examples i ran into an unhandled exception when using an out of bounds regex group in the replacement e.g. '$99'. I also applied my fix to EffReplace, hope thats okay!

[APickledWalrus]

Looks pretty good, just a few things :)

[novystar]

hey @APickledWalrus waiting on approval for those changes when you can, thanks 🙏

[APickledWalrus]

Just about there! Thanks for your work so far 🙂

[APickledWalrus]

Great work!