[3.0] Deprecate hooks without standard prefixes#9253
Merged
Conversation
Darknico
reviewed
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds new integration hooks to the Who's Online action processing flow while preserving backward compatibility with existing hooks.
Changes
integrate_who_allowedhook before action determination begins, allowing integrations to modify the list of allowed actions used byWho::determineActions().integrate_whos_online_afterhook after Who's Online data has been processed, allowing integrations to inspect or modify the generated URL list and user activity data.who_allowedandwhos_online_afterhooks for backward compatibility.integrate_hook naming convention.Why
The existing hooks were created without the standard
integrate_prefix used throughout SMF's integration system. Adding correctly named hooks provides a consistent API for new integrations while ensuring older modifications continue to function unchanged.Compatibility
who_allowedorwhos_online_afterwill continue to work.integrate_who_allowedandintegrate_whos_online_afterinstead.