Repository navigation
[#33475] DocDB: Count safe-time rejections and their deficit - #27
Open
Hasan-Al-Khazraji wants to merge 1 commit into
Open
Hasan-Al-Khazraji wants to merge 1 commit into
Hasan-Al-Khazraji wants to merge 1 commit into
Conversation
Retry totals cannot distinguish a follower refusing an unsafe read time from other RPC failures. Record the rejection and its physical-time shortfall at the existing fast-fail point, without changing read semantics. The deficit uses native event stats (sum/count), not Prometheus buckets. These metrics are tablet-level and are not returned in the failed query's EXPLAIN response. Related proposal: yugabyte#33475. Test plan: - Independent source review and git diff --check passed. - Scoped lint passes with existing PostgreSQL marker warnings. - Added PgMiniTest.FollowerReadRejectionMetrics; not executed because this checkout has no prepared C++ build. Validate before marking ready.
Hasan-Al-Khazraji
had a problem deploying
to
jenkins
October 14, 2026 19:21 — with 
GitHub Actions
Error
GitHub Actions
Error
Hasan-Al-Khazraji
marked this pull request as ready for review
October 16, 2026 17:54
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry totals cannot distinguish a follower refusing an unsafe read time
from other RPC failures. Record the rejection and its physical-time
shortfall at the existing fast-fail point, without changing read semantics.
The deficit uses native event stats (sum/count), not Prometheus buckets.
These metrics are tablet-level and are not returned in the failed query's
EXPLAIN response. Related proposal: yugabyte#33475.
Test plan
git diff --checkcompleted for92ec3ba.PgMiniTest.FollowerReadRejectionMetricsto check rejection counting,safe-time deficit sampling, and an accepted read leaving both unchanged.
The test has not been executed; compilation and runtime validation are pending.
bld-dbjob never reached compilation: it timed out after24 hours waiting for a
ybdbghrrunner.Ready for code review, not merge. A development build environment still needs
to be identified or set up so the focused test can run before merge.