Repository navigation
Bump minimum Rust version to 1.99.1 - #1092
Merged
Merged
Conversation
vinistock
force-pushed
the
vs_bump_minimum_rust
branch
from
October 28, 2026 11:53
c707ca1 to
c30c1af
Compare
st0012
approved these changes
Oct 28, 2026
Member
|
@vinistock Do we need to update our release workflows too? |
Member
Author
|
I did. The |
|
You may want to cut a new release soon-ish, since 0.4.3 was built with the buggy Rust version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1089
There's a Rust compilation bug in 1.99 that hit our latest release and makes boolean values incorrect. This PR bumps the minimum to 1.99.1, which contains the fix.
This also requires making sure CI and release use the latest Rust since images come with 1.99.0 (the buggy version).