Skip to content

Bump minimum Rust version to 1.99.1 - #1092

Merged
vinistock merged 1 commit into
mainfrom
vs_bump_minimum_rust
Oct 28, 2026
Merged

vinistock merged 1 commit into
mainfrom
vs_bump_minimum_rust

Conversation

@vinistock

@vinistock vinistock commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Closes #1089

There's a Rust compilation bug in 1.99 that hit our latest release and makes boolean values incorrect. This PR bumps the minimum to 1.99.1, which contains the fix.

This also requires making sure CI and release use the latest Rust since images come with 1.99.0 (the buggy version).

@vinistock vinistock self-assigned this Oct 28, 2026
@vinistock vinistock added the bugfix A change that fixes an existing bug label Oct 28, 2026
@vinistock
vinistock requested a review from a team as a code owner October 28, 2026 11:49
@vinistock
vinistock force-pushed the vs_bump_minimum_rust branch from c707ca1 to c30c1af Compare October 28, 2026 11:53
@st0012

st0012 commented Oct 28, 2026

Copy link
Copy Markdown
Member

@vinistock Do we need to update our release workflows too?

@vinistock

Copy link
Copy Markdown
Member Author

I did. The release.yml file is the release workflow.

@vinistock
vinistock merged commit 81337bf into main Oct 28, 2026
45 of 46 checks passed
@vinistock
vinistock deleted the vs_bump_minimum_rust branch October 28, 2026 17:09
@bquorning

Copy link
Copy Markdown

You may want to cut a new release soon-ish, since 0.4.3 was built with the buggy Rust version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix A change that fixes an existing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Definition#deprecated? returns true for plain constants on x86_64 when built with rustc 1.99.0

3 participants