Repository navigation
fix(resolution): resolve constants under implicit namespaces - #1088
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A compactly defined namespace can begin as a TODO and later be promoted to a class or module. That promotion was losing its tracked descendants, leaving child classes with stale ancestor chains and top-level constant references unresolved. This preserves descendant tracking and re-invalidates affected descendants in the same resolution pass. Regression tests cover implicit and explicit namespaces plus a sibling-superclass control against both resolver backends. The failing case was reproduced before the fix. Verified: Rust workspace tests (1,163 rubydex tests, 9 CLI tests, 12 rubydex-sys tests and 2 doctests), Clippy, formatting, build and a Ruby runtime check. Fixes #1087.