Develop - #699
Merged
Merged
Conversation
I have applied the fix described in the vulnerability report GHSA-j6gq-jchg-q883.
Update auth.py to fix LDAP injection vulnerability
… file is promoted to custom_poster.webp with os.replace only when ffmpeg exits 0 and produced a non-empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the custom poster upload process, enhances LDAP username handling for authentication, and updates the package version. The main changes focus on making file handling safer during poster uploads and improving security for LDAP logins.
Custom Poster Upload Improvements:
upload_custom_posternow uses a temporary file withinderived_dirto ensure atomic replacement and prevent corruption ofcustom_poster.webpifffmpegfails. The code also checks for empty output files and sets correct file permissions before replacing the final poster.LDAP Authentication Security:
ldap.filter.escape_filter_charsin LDAP filter construction to prevent LDAP injection vulnerabilities.ldap.filterto support the escaping function.Versioning:
fireshareclient package version from1.7.7to1.7.8.