speed up script for regen metric signatures#134
Open
katstankiewicz wants to merge 3 commits into
Open
Conversation
weiz9
reviewed
Jun 5, 2026
| from importlib.machinery import ModuleSpec | ||
| from pathlib import Path | ||
| from types import ModuleType | ||
| from typing import TypedDict |
There was a problem hiding this comment.
I tested the PR on python 3.11 and crashed with PydanticUserError: Please use typing_extensions.TypedDict. Do we want to use "typing_extensions import TypedDict" instead since pyproject.toml supports 3.11 and DeploymentTypedDict is used as a pydantic base. Other than that everything looks good, went from 8s - 3s locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script itself was quick but imported pipecat and all of eva which was slow ~4-5s.
This removes some unused imports and add stubs
Brings down the time to ~1-2s