fix(fast-llm): stop producers and helpers on training completion#144
Merged
jlamypoirier merged 2 commits intoJun 5, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpt-5 Codex note:
This is a fixup for PR #142. It extends the Fast-LLM early-stop fix beyond the actor path.
Changes:
training_finishedevent before stopping, instead of the legacy sample-counting heuristic.Why:
samples_processedreflects Redis entries read, not natural optimizer completion, so preprocessing could still stop converting actor rollouts intofast_llm_streamingdocuments too early.Verification from the local branch:
/Users/joel.lamy-poirier/Projects/Fast-LLM/venv/bin/python -m py_compile pipelinerl/launch.py pipelinerl/preprocess.py tests/test_launch_process_monitoring.pygit diff --checktests/conftest.pyimportspipelinerl.vllm1, which requiresuvloop.