Re-enable dropless MoE test; fix VISION extra on aarch64#532
Merged
Conversation
The dropless MoE kernel was fixed in #489 but the dedicated test_dropless_mlp skip was left behind. Remove it; the test passes on GPU. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pillow-simd is an x86-only (SSE4) fork with no aarch64 build, so the VISION extra fails to install on ARM. Gate it to x86_64 via an environment marker and fall back to stock Pillow on other architectures. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Opus 4.8:
Two small, independent fixes surfaced while triaging the backlog.
Re-enable dropless MoE test. #489 fixed and reworked the dropless MoE kernel, but the standalone
tests/functional/test_functional.py::test_dropless_mlpwas left marked@pytest.mark.skip("Dropless MoE is broken"). Removed the skip — verified passing on a CUDA GPU (1 passed in 9.41s).Fix VISION extra install on aarch64 (closes #429).
pillow-simdis an x86-only (SSE4) fork with no aarch64 build, sopip install ".[VISION]"fails on ARM. Gatedpillow-simdtoplatform_machine == "x86_64"and fall back to stockPillowon other architectures. Using!= "x86_64"(rather than== "aarch64") also covers macOS arm64.Verified on arm64: pip skips pillow-simd (
Ignoring pillow-simd: markers ... don't match your environment) and resolves/installsPillow, which imports cleanly. No Linux-aarch64 box was available to exercise the real install, butPillowships manylinux-aarch64 wheels so no source build is triggered.🤖 Generated with Claude Code