fix(changelog): use legend framework labels for updated-config entries / 修复 changelog 下拉框 Updated Configs 使用与图例一致的框架名映射#544
Open
cquil11 wants to merge 1 commit into
Open
Conversation
formatConfigKeys treated everything after the GPU segment as one
framework token, so config keys with trailing descriptors (e.g.
sglang-agentic-hicache) missed the FRAMEWORK_LABELS lookup and fell
back to shouted caps ("SGLANG AGENTIC HICACHE"). Greedy-match the
longest known framework prefix — the same mapping the chart legend
uses — and title-case the leftover descriptors, so the dropdown reads
"B200 (SGLang, Agentic, Hicache)". MTP/EAGLE handling now applies to
any descriptor position instead of only a trailing -mtp.
中文:changelog 下拉框中"Updated Configs"此前将 GPU 之后的全部片段当作
单个框架 token,带描述符的 config key(如 sglang-agentic-hicache)无法
命中 FRAMEWORK_LABELS 映射而回退为全大写。现改为按图例使用的同一框架
映射(最长前缀匹配)解析框架名,剩余描述符首字母大写显示。
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The changelog dropdown's Updated Configs list formatted the framework segment of each config key with its own broken mapping: everything after the GPU token was treated as a single framework id, so keys with trailing descriptors (
dsv4-fp4-b200-sglang-agentic-hicache) missed theFRAMEWORK_LABELSlookup and fell back to per-token uppercase — rendering as "B200 (SGLANG AGENTIC HICACHE)" instead of using the same framework labels shown in the chart legend.formatConfigKeysnow:sglang-disagg→mori-sglang), then greedy-matches the longest known framework prefix againstFRAMEWORK_LABELS— the exact mapping the legend uses — so multi-token frameworks (dynamo-sglang,llmd-vllm,mori-sglang) resolve correctly ahead of any descriptorsmtpstill renders as "EAGLE") and now applies them in any descriptor position, not just a trailing-mtpNo behavior change for plain keys (
…-b200-vllm,…-h200-sglang-mtp,…-b200-dynamo-sglangrender exactly as before — covered by the existing tests).Tests: 3 new cases (descriptor split, multi-token framework + descriptor, EAGLE after descriptor); all 17 pass.
tsc --noEmit, oxlint, oxfmt clean.中文说明
changelog 下拉框的 Updated Configs 列表此前使用一套独立且有误的框架名映射:GPU 之后的全部片段被当作单个框架 id,带描述符的 config key(如
dsv4-fp4-b200-sglang-agentic-hicache)无法命中FRAMEWORK_LABELS,回退为逐词全大写(显示为 "B200 (SGLANG AGENTIC HICACHE)"),与图例中的框架显示不一致。formatConfigKeys现在:sglang-disagg→mori-sglang),再按 图例所用的同一FRAMEWORK_LABELS映射做最长前缀匹配,确保多段框架名(dynamo-sglang、llmd-vllm、mori-sglang)优先于描述符正确解析mtp仍显示为 "EAGLE"),且不再局限于末尾-mtp位置普通 config key 的显示不变(现有测试覆盖)。新增 3 个单元测试,17 个测试全部通过;
tsc --noEmit、oxlint、oxfmt 均通过。Note
Low Risk
Display-only formatter change in changelog UI with targeted tests and no API or data-path changes.
Overview
Fixes Updated Configs in the changelog dropdown so framework names match the chart legend instead of shouting unknown tail tokens.
formatConfigKeysno longer treats everything after the GPU as one framework id. It canonicalizes legacy aliases, then greedy longest-prefix matches againstFRAMEWORK_LABELSso multi-token frameworks (llmd-vllm,dynamo-sglang) resolve before descriptors likeagentic/hicache, which are comma-separated and title-cased. Model-specificmtplabels (e.g. M3 → EAGLE) still apply in any suffix position, not only a trailing-mtp.Three unit tests cover descriptor splits, multi-token frameworks + descriptors, and EAGLE after descriptors; plain keys stay unchanged per existing tests.
Reviewed by Cursor Bugbot for commit e15aab6. Bugbot is set up for automated code reviews on this repo. Configure here.