Skip to content

fix(changelog): use legend framework labels for updated-config entries / 修复 changelog 下拉框 Updated Configs 使用与图例一致的框架名映射#544

Open
cquil11 wants to merge 1 commit into
masterfrom
fix/updated-configs-labels
Open

fix(changelog): use legend framework labels for updated-config entries / 修复 changelog 下拉框 Updated Configs 使用与图例一致的框架名映射#544
cquil11 wants to merge 1 commit into
masterfrom
fix/updated-configs-labels

Conversation

@cquil11

@cquil11 cquil11 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

The changelog dropdown's Updated Configs list formatted the framework segment of each config key with its own broken mapping: everything after the GPU token was treated as a single framework id, so keys with trailing descriptors (dsv4-fp4-b200-sglang-agentic-hicache) missed the FRAMEWORK_LABELS lookup and fell back to per-token uppercase — rendering as "B200 (SGLANG AGENTIC HICACHE)" instead of using the same framework labels shown in the chart legend.

formatConfigKeys now:

  • canonicalizes legacy aliases first (sglang-disaggmori-sglang), then greedy-matches the longest known framework prefix against FRAMEWORK_LABELS — the exact mapping the legend uses — so multi-token frameworks (dynamo-sglang, llmd-vllm, mori-sglang) resolve correctly ahead of any descriptors
  • renders leftover descriptor tokens title-cased and comma-separated: "B200 (SGLang, Agentic, Hicache) DeepSeek-V4-Pro FP4"
  • keeps the per-model spec-method labels (M3's mtp still renders as "EAGLE") and now applies them in any descriptor position, not just a trailing -mtp

No behavior change for plain keys (…-b200-vllm, …-h200-sglang-mtp, …-b200-dynamo-sglang render exactly as before — covered by the existing tests).

Tests: 3 new cases (descriptor split, multi-token framework + descriptor, EAGLE after descriptor); all 17 pass. tsc --noEmit, oxlint, oxfmt clean.

中文说明

changelog 下拉框的 Updated Configs 列表此前使用一套独立且有误的框架名映射:GPU 之后的全部片段被当作单个框架 id,带描述符的 config key(如 dsv4-fp4-b200-sglang-agentic-hicache)无法命中 FRAMEWORK_LABELS,回退为逐词全大写(显示为 "B200 (SGLANG AGENTIC HICACHE)"),与图例中的框架显示不一致。

formatConfigKeys 现在:

  • 先规范化旧别名(sglang-disaggmori-sglang),再按 图例所用的同一 FRAMEWORK_LABELS 映射做最长前缀匹配,确保多段框架名(dynamo-sglangllmd-vllmmori-sglang)优先于描述符正确解析
  • 剩余描述符 token 首字母大写、逗号分隔显示:"B200 (SGLang, Agentic, Hicache) DeepSeek-V4-Pro FP4"
  • 保留按模型的投机解码标签(MiniMax-M3 的 mtp 仍显示为 "EAGLE"),且不再局限于末尾 -mtp 位置

普通 config key 的显示不变(现有测试覆盖)。新增 3 个单元测试,17 个测试全部通过;tsc --noEmit、oxlint、oxfmt 均通过。


Note

Low Risk
Display-only formatter change in changelog UI with targeted tests and no API or data-path changes.

Overview
Fixes Updated Configs in the changelog dropdown so framework names match the chart legend instead of shouting unknown tail tokens.

formatConfigKeys no longer treats everything after the GPU as one framework id. It canonicalizes legacy aliases, then greedy longest-prefix matches against FRAMEWORK_LABELS so multi-token frameworks (llmd-vllm, dynamo-sglang) resolve before descriptors like agentic / hicache, which are comma-separated and title-cased. Model-specific mtp labels (e.g. M3 → EAGLE) still apply in any suffix position, not only a trailing -mtp.

Three unit tests cover descriptor splits, multi-token frameworks + descriptors, and EAGLE after descriptors; plain keys stay unchanged per existing tests.

Reviewed by Cursor Bugbot for commit e15aab6. Bugbot is set up for automated code reviews on this repo. Configure here.

formatConfigKeys treated everything after the GPU segment as one
framework token, so config keys with trailing descriptors (e.g.
sglang-agentic-hicache) missed the FRAMEWORK_LABELS lookup and fell
back to shouted caps ("SGLANG AGENTIC HICACHE"). Greedy-match the
longest known framework prefix — the same mapping the chart legend
uses — and title-case the leftover descriptors, so the dropdown reads
"B200 (SGLang, Agentic, Hicache)". MTP/EAGLE handling now applies to
any descriptor position instead of only a trailing -mtp.

中文:changelog 下拉框中"Updated Configs"此前将 GPU 之后的全部片段当作
单个框架 token,带描述符的 config key(如 sglang-agentic-hicache)无法
命中 FRAMEWORK_LABELS 映射而回退为全大写。现改为按图例使用的同一框架
映射(最长前缀匹配)解析框架名,剩余描述符首字母大写显示。
@cquil11 cquil11 requested a review from adibarra as a code owner July 9, 2026 19:38
@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
inferencemax-app Ready Ready Preview, Comment Jul 9, 2026 7:38pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant