Repository navigation
refactor(seismic): name the setup scripts after their units - #77
Merged
Merged
Conversation
persistent-luks-setup.service ran /usr/bin/setup-persistent-luks, and nginx-ssl-setup.service ran /usr/bin/setup-nginx-ssl. The scripts now carry their units' names, so the name in a log line, a status message or a doc is the one systemctl and journalctl -u take. The units keep their names: they put the component first, like the rest of the image's units. Nothing outside this repo runs the scripts by name. Other repos mention them only in comments and docs, which follow once this merges.
The previous commit dropped its mode from 755 to 644, and mkosi refuses to run a postinst that is not executable.
samlaf
added a commit
to SeismicSystems/seismic
that referenced
this pull request
Oct 6, 2026
seismic-images renamed the disk script after its unit (SeismicSystems/seismic-images#77), so architecture.md's link to it no longer resolved. That link, the key schedule's consumer column and a status.rs comment follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
persistent-luks-setup.service ran /usr/bin/setup-persistent-luks, and nginx-ssl-setup.service ran /usr/bin/setup-nginx-ssl. The scripts now carry their units' names, so the name in a log line, a status message or a doc is the one systemctl and journalctl -u take. The units keep their names: they put the component first, like the rest of the image's units.
Nothing outside this repo runs the scripts by name. Other repos mention them only in comments and docs, which follow once this merges.