[CI] Fix for build.yml and writing version.json - #956
Merged
Merged
Conversation
newtonick
marked this pull request as ready for review
July 22, 2026 19:47
Collaborator
Author
|
Because current CI is broken; I am going to fast track this PR to be merged. In general I always want the dev/main branches of both of these repos in working states. I see regard changes to the GitHub actions mostly as a low risk activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem or Issue being addressed
Build images (.img files) produced by the SeedSigner CI build action hang at the logo after being flashed, even though the build passes.
#858 added a Version screen that reads
src/seedsigner/version.jsonduring startup. If the file is missing or incomplete, the resulting exception terminates the app.The
delete unnecessary filesstep reduces the checkout tosrc/before the build container starts:This removes
.git/andtools/, whichtools/write_versionfile.pyneeds to generateversion.json. The build log confirms that onlysrc/remains when the container runs.Solution
Remove the
delete unnecessary filesworkflow step. The updated seedsigner-osbuild.shwrites the version file first, then callsdelete_unnecessary_files()before Buildroot packages the image.I checked its removal list against every top-level entry in this repository.
.git/,tools/, and the other unnecessary files are removed beforemake, so they do not reach the image.After the build, validate the generated file with
jq:jq -e '.name and .fork and .short_commit_hash and .timestamp' src/seedsigner/version.jsonA failed version write still stops the build immediately. This additional check catches an incomplete file that might otherwise ship in an unbootable image.
Additional Information
This requires the matching seedsigner-os PR SeedSigner/seedsigner-os#115 to be merged first. It runs the version-writing step during
--skip-repobuilds and sets Git'ssafe.directoryso the container can read the version data.Screenshots
N/A. This PR only changes the CI build workflow.
This pull request is categorized as a:
Checklist
I ran pytest locally
I included screenshots of any new or modified screens
Should be part of the PR description above.
I added or updated tests
Any new or altered functionality should be covered in a unit test. Any new or updated sequences require FlowTests.
I tested this PR hands-on on the following platform(s):
I have reviewed these notes: