Skip to content

[sanity check] Reject a PSBT whose fingerprint records disagree #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kdmukai wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

[sanity check] Reject a PSBT whose fingerprint records disagree #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98b46f5
Rename _derive_with_cache to _derive_with_cache_via_indices
kdmukai Sep 19, 2026
e1cd05d
Hold every claim of ours on a multisig output to its script
kdmukai Sep 19, 2026
d6b4d5a
Refuse a key whose two fingerprint records disagree
kdmukai Sep 20, 2026
be6dbc1
Note the all-zero fingerprint seed edge case
kdmukai Sep 20, 2026
ccaf1a5
Check fingerprint records on single-sig psbts too
kdmukai Sep 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/seedsigner/helpers/mnemonic_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@
verification of SeedSigner's results for a given input entropy.

see: docs/dice_verification.md (the "Command Line Tool" section).

TODO: warn the user when a newly generated seed's fingerprint is 00000000 (one seed in
2^32). Coordinators write all zeros for a fingerprint they do not know. SeedSigner
handles all-zero fingerprints gracefully for single sig. Multisig has a bad rare edge
case: a coordinator that lists all-zero fingerprints for at least two cosigners but
the user's actual fingerprint is correctly all zeros. Other software or signing
devices may have other issues when dealing with an all-zero fingerprint seed. Warn the
user and recommend that they generate a different new seed.
"""

DICE__NUM_ROLLS__12WORD = 50
Expand Down
Loading
Loading