ci: repin fleet-ci so this repo's own deny.toml is used again - #10
Merged
Merged
Conversation
The shared workflow's `deny-config-repo` input defaulted to SecurityRonin/fleet-config, so adopting it silently replaced this repo's supply-chain policy with the shared one. That is a real change to what `cargo deny` accepts, and no adoption PR disclosed it — nobody involved knew. Measured across the fleet when it was found: 61 of 65 adopted repos had a stricter local config. The shared one carries 21 advisory ignores against their `ignore = []`, every one a bare RUSTSEC id with no reason and no removal condition — which the fleet's own suppression rule forbids. Among them RUSTSEC-2023-0071 (rsa, Marvin timing attack). Several repos also went from `bans.multiple-versions = "deny"` to `"warn"` and gained nine allowed licences. fleet-ci now defaults to the repository's own deny.toml; opting into the shared config is explicit. This repin picks that up, restoring the policy this repo actually wrote. Reassuring rather than alarming: before this fix all 65 adopted repos were re-checked against their OWN deny.toml and all 65 passed. The gate was weakened, but nothing was hiding behind it. If this repin does turn a check red, that is a true finding this repo's own policy always meant to catch — fix it rather than re-pointing at the shared config. Only the pinned SHA changes.
`ci / Clippy` runs `cargo clippy --workspace --all-targets --all-features -- -D warnings`, which promotes `clippy::doc_markdown` to an error. Two doc lines named the Unicode property `General_Category` unbackticked while backticking `White_Space` and `Cf` on the same line, so clippy flagged the inconsistency: src/inspect.rs:350 error: item in documentation is missing backticks src/text.rs:426 error: item in documentation is missing backticks Applied clippy's own suggestion, which also makes the three property names on those lines render consistently. No `#[allow]` — the lint is correct here. Worth noting for anyone reproducing: a bare `cargo clippy` reports these as warnings and exits 0. Only the job's own `-- -D warnings` turns them into the error CI sees. Control (revert -> fail -> restore), same commit, same command: with fix -> exit 0, 0 errors fix reverted -> exit 101, 2 doc_markdown errors restored -> exit 0 `cargo fmt --check` clean. Only `ci / Clippy` was in scope; no other check was touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared workflow's
deny-config-repoinput defaulted toSecurityRonin/fleet-config, so adopting it silently replaced this repo's
supply-chain policy with the shared one. That is a real change to what
cargo denyaccepts, and no adoption PR disclosed it — nobody involved knew.Measured across the fleet when it was found: 61 of 65 adopted repos had a
stricter local config. The shared one carries 21 advisory ignores against their
ignore = [], every one a bare RUSTSEC id with no reason and no removalcondition — which the fleet's own suppression rule forbids. Among them
RUSTSEC-2023-0071 (rsa, Marvin timing attack). Several repos also went from
bans.multiple-versions = "deny"to"warn"and gained nine allowed licences.fleet-ci now defaults to the repository's own deny.toml; opting into the shared
config is explicit. This repin picks that up, restoring the policy this repo
actually wrote.
Reassuring rather than alarming: before this fix all 65 adopted repos were
re-checked against their OWN deny.toml and all 65 passed. The gate was weakened,
but nothing was hiding behind it. If this repin does turn a check red, that is a
true finding this repo's own policy always meant to catch — fix it rather than
re-pointing at the shared config.
Only the pinned SHA changes.