gmic-qt: Add version 3.7.6#17905
Open
scillidan wants to merge 3 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds a new Scoop package manifest file bucket/gmic-qt.json for G'MIC-Qt version 3.7.6. The manifest includes metadata (description, homepage, license), a Windows 64-bit download URL and SHA-256 hash with extract_dir, a shortcut mapping gmic_qt.exe → G'MIC-Qt, a checkver regex targeting the homepage, and an autoupdate rule using a $version-templated win64 URL. Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
bucket/gmic-qt.json (1)
1-30: Testing instructions before merge.Please test the manifest locally using the following steps:
Optional: Enable debug mode and set GitHub token (for GitHub API access during version checks):
scoop config debug true scoop config gh_token <your-github-token> # Read access onlyForce version detection and autoupdate to verify the checkver and autoupdate configuration:
.\bin\checkver.ps1 -App gmic-qt -fAuto-format (Lint) the JSON manifest to ensure proper formatting:
.\bin\formatjson.ps1 -App gmic-qtTest installation for 64-bit architecture:
scoop install .\bucket\gmic-qt.json -a 64bitFor more details, see the Contribution Guide.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/gmic-qt.json` around lines 1 - 30, Manifest lacks local verification steps—please run the recommended tests: enable debug and set a GitHub token (scoop config debug true; scoop config gh_token <token>), force version detection with .\bin\checkver.ps1 -App gmic-qt -f to validate the "checkver" regex and discovered version, run .\bin\formatjson.ps1 -App gmic-qt to lint the JSON, install the 64-bit manifest with scoop install .\bucket\gmic-qt.json -a 64bit and confirm the installed files match "extract_dir" and the "shortcuts" entry launches gmic_qt.exe, and finally verify the "autoupdate" URL substitution (gmic_$version_qt_win64.zip) produces a valid download URL.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/gmic-qt.json`:
- Around line 1-5: The manifest currently uses LF line endings; convert the file
to CRLF line endings so the JSON keys such as "version", "description",
"homepage", and "license" in bucket/gmic-qt.json end each line with \r\n; ensure
your editor or git normalisation writes CRLF for this file (or run a line-ending
conversion tool) and re-commit so the repository contains the CRLF-terminated
manifest.
- Line 12: The autoupdate block is missing a parameterized extract_dir and still
relies on the hardcoded top-level "extract_dir"; update the autoupdate section
to include an extract_dir that uses the version variable (e.g., set
autoupdate.extract_dir to the same pattern as the top-level but using $version)
so it becomes something like "gmic-$version-qt-win64", ensuring autoupdate will
extract the correct folder for new versions; modify the autoupdate block where
extract_dir is defined (and any related autoupdate.url if necessary) to use the
$version variable rather than the hardcoded 3.7.6.
---
Nitpick comments:
In `@bucket/gmic-qt.json`:
- Around line 1-30: Manifest lacks local verification steps—please run the
recommended tests: enable debug and set a GitHub token (scoop config debug true;
scoop config gh_token <token>), force version detection with .\bin\checkver.ps1
-App gmic-qt -f to validate the "checkver" regex and discovered version, run
.\bin\formatjson.ps1 -App gmic-qt to lint the JSON, install the 64-bit manifest
with scoop install .\bucket\gmic-qt.json -a 64bit and confirm the installed
files match "extract_dir" and the "shortcuts" entry launches gmic_qt.exe, and
finally verify the "autoupdate" URL substitution (gmic_$version_qt_win64.zip)
produces a valid download URL.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5110e7d3-4280-4661-94fc-d75a937a21aa
📒 Files selected for processing (1)
bucket/gmic-qt.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
bucket/gmic-qt.json (1)
12-36:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winFix invalid JSON in bucket/gmic-qt.json (duplicate “autoupdate” + missing comma).
- No comma after the first top-level
"autoupdate"block before"shortcuts"(around lines 19–20), causing JSON parsing to fail.- Two top-level
"autoupdate"blocks exist (around lines 12–19 and 30–36); consolidate into a single block (keepextract_dirand parameterized$version).🔧 Proposed minimal fix
- "autoupdate": { - "architecture": { - "64bit": { - "url": "https://gmic.eu/get_file.php?file=windows/gmic_$version_qt_win64.zip", - "extract_dir": "gmic-$version-qt-win64" - } - } - } + "autoupdate": { + "architecture": { + "64bit": { + "url": "https://gmic.eu/get_file.php?file=windows/gmic_$version_qt_win64.zip", + "extract_dir": "gmic-$version-qt-win64" + } + } + }, @@ - "autoupdate": { - "architecture": { - "64bit": { - "url": "https://gmic.eu/get_file.php?file=windows/gmic_$version_qt_win64.zip" - } - } - }Run
.\\bin\\formatjson.ps1 -App gmic-qtafter applying the change.
Contribution guidance: https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/gmic-qt.json` around lines 12 - 36, The JSON has a duplicate top-level "autoupdate" and a missing comma between the first "autoupdate" block and the "shortcuts" array; remove the second "autoupdate" block and merge its contents into the first "autoupdate" so the 64bit entry keeps the parameterized "url" (with $version) and the "extract_dir" field, then add the missing comma after the first "autoupdate" object so "shortcuts" is a separate property; ensure the final manifest contains a single "autoupdate" object with "architecture" -> "64bit" -> { "url": "https://gmic.eu/get_file.php?file=windows/gmic_$version_qt_win64.zip", "extract_dir": "gmic-$version-qt-win64" } and keep "shortcuts" and "checkver" as shown.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@bucket/gmic-qt.json`:
- Around line 12-36: The JSON has a duplicate top-level "autoupdate" and a
missing comma between the first "autoupdate" block and the "shortcuts" array;
remove the second "autoupdate" block and merge its contents into the first
"autoupdate" so the 64bit entry keeps the parameterized "url" (with $version)
and the "extract_dir" field, then add the missing comma after the first
"autoupdate" object so "shortcuts" is a separate property; ensure the final
manifest contains a single "autoupdate" object with "architecture" -> "64bit" ->
{ "url": "https://gmic.eu/get_file.php?file=windows/gmic_$version_qt_win64.zip",
"extract_dir": "gmic-$version-qt-win64" } and keep "shortcuts" and "checkver" as
shown.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6c2409ac-1eaa-4302-bb29-68cfa3d4d9e9
📒 Files selected for processing (1)
bucket/gmic-qt.json
Contributor
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. gmic-qt
|
arvdk
added a commit
to arvdk/Extras
that referenced
this pull request
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17904
<manifest-name[@version]|chore>: <general summary of the pull request>