Skip to content

optimize ConversationStateService #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iceljc merged 2 commits into from
Apr 9, 2026
Merged

optimize ConversationStateService #1320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b73bed
optimize ConversationStateService
yileicn Apr 9, 2026
c591732
simplify state Save
yileicn Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Infrastructure/BotSharp.Core/Conversations/Services/ConversationStateService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public class ConversationStateService : IConversationStateService
/// States in the previous rounds of conversation
/// </summary>
private ConversationState _historyStates;
private bool _isReadOnly;

public ConversationStateService(
IServiceProvider services,
Expand Down Expand Up @@ -153,7 +154,8 @@ public IConversationStateService SetState<T>(string name, T value, bool isNeedVe

public async Task<Dictionary<string, string>> Load(string conversationId, bool isReadOnly = false)
{
_conversationId = !isReadOnly ? conversationId : null;
_isReadOnly = isReadOnly;
_conversationId = conversationId;
Reset();

var endNodes = new Dictionary<string, string>();
Expand Down Expand Up @@ -232,7 +234,7 @@ public async Task<Dictionary<string, string>> Load(string conversationId, bool i

public async Task Save()
{
if (_conversationId == null || _sidecar?.IsEnabled == true)
if (_conversationId == null || _sidecar?.IsEnabled == true || _isReadOnly)
{
return;
}
Expand Down
Loading