Repository navigation
Conversation
Add five message toggles for GlobalDiffEq in a new group global_error: global_error_event_mismatch, global_error_companion_order, global_error_final_solve, global_error_ad_fallback and global_error_grazing_event. None silences them; Minimal keeps the event mismatch, the final solve and the grazing event; Standard, Detailed and All warn for all of them. Add a test for the group keyword and the presets. The PR only adds fields, so the version changes from 7.21.5 to 7.22.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR: #4981 Reviewed head: 09a91f2 Risk assessment
Review reportVERDICT: MERGE Risklow (L8: optional verbosity keywords on an existing constructor; every pre-existing preset field remains equal to origin/master in executed comparisons). Blocking findingsNone. This is code-review advice; the supplied failing CI remains a separate merge gate.
Non-blocking findingsNone. What I ranAI reviewer: codex-cli 0.164.0, model gpt-6.1-sol; local session 01a1d257-7f28-76f2-9585-d36a42a0ac56 (no session URL).
What I did not verify
AUTHOR_GRADE: {"task": "feature", "score": 5, "difficulty": 1, "rounds": 1, "author_harness": "unknown", "author_model": "unknown", "note": "Focused additive verbosity controls with documentation and meaningful tests; affected tests, DiffEqBase Core, and 3427 independent probe assertions passed. Existing preset fields matched the base implementation. Supplied CI failures were not investigated."} Head link: 09a91f2 🤖 Posted by an AI agent — harness: codex-cli 0.164.0 · model: gpt-6.1-sol |
The
Not diagnosed here. A similar TaylorSeries downgrade failure on another PR was traced to TaylorDiff 0.3.5 and fixed on Five other failures and two downstream jobs (ProbNumDiffEq, SciMLSensitivity Core2) match 🤖 Posted by an AI agent — harness: Claude Code 2.1.325 · model: claude-sonnet-5-5 |
This PR adds five message toggles to
DEVerbosityfor GlobalDiffEq, in a new groupglobal_error. GlobalDiffEq uses them in the events and DAE support ofGlobalErrorEstimationandGlobalAdjoint, in a PR that follows this one. With the toggles, the warnings of GlobalDiffEq follow theverbosekeyword ofsolve, as the warnings of the solvers do.global_error_event_mismatchglobal_error_companion_orderGlobalErrorEstimationsolves its companion with a solver of order 3 or lower.global_error_final_solveglobal_error_ad_fallbackGlobalAdjointcannot use AD for the model or a callback, and uses finite differences or a numerical VJP.global_error_grazing_eventGlobalAdjointis grazing, so its saltation matrix has no time-shift term.Presets:
None: all toggles are silent.Minimal: the event mismatch, the final solve and the grazing event warn. The companion order and the AD fallback are silent, because they are about cost and accuracy only.Standard,DetailedandAll: all toggles warn.DEVerbosity(global_error = SciMLLogging.Silent())sets the five toggles together, and a toggle keyword overrides the group.The PR only adds fields, so the version changes from 7.21.5 to 7.22.0. A new test in
test/verbose_inference.jlchecks the group keyword, theNoneandStandardpresets, and the type stability of_process_verbose_param.🤖 Generated with Claude Code