Repository navigation
Clarify EEst handling in controller snapshot docstrings; note Forward… - #4972
Open
bobby404-K wants to merge 1 commit into
Open
bobby404-K wants to merge 1 commit into
bobby404-K wants to merge 1 commit into
Conversation
Member
|
The new text says EEst lives on the integrator, but get_EEst/set_EEst! read and write controller_cache.EEst (controllers.jl:171-186). It's left out of the snapshots because sync_controllers! only copies dtreject (:755), so that's what the sentence should say. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4964.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Addresses both follow-ups from the review of #4766:
snapshot_controller/restore_controller!docstrings (lib/OrdinaryDiffEqCore/src/integrators/controllers.jl): now state that the snapshot covers controller scratch state only and does not includeEEst, which lives on the integrator. Added an example showing how callers preserveEEstwhile pseudo-stepping, mirroring whatOrdinaryDiffEqTaylorSeriesalready does in its adaptive-order step.lib/OrdinaryDiffEqTaylorSeries/Project.toml): added a comment noting it is MIT-licensed and used only in the "AdaptiveOrder Dual tspan derivative" test.No functional code changes.