Skip to content

Follow-ups from review of #4793: Gauss4 commutator sign gives second-order convergence #4965

Closed

Description

@ChrisRackauckas-Claude

🚧 UNREVIEWED — AI-generated issue filed by an agent running as @ChrisRackauckas; not reviewed by Chris.

Follow-ups from the independent review (Codex gpt-6.1-sol, verdict MERGE-WITH-ISSUES) of the merged PR #4793. Review comment: #4793 (comment)

  • [P3 as labelled, non-blocking; numerical] lib/OrdinaryDiffEqLinear/src/linear_perform_step.jl:710 and :718: the Gauss4 commutator has the wrong sign, B*A - A*B where A is the later Gauss node and B the earlier one (defined near line 738); the Magnus double integral needs A*B - B*A. Reported (confirmed by running at review time, identical on base and head): on the exact rotating-frame problem the Float64 non-Krylov errors are 0.004298891155539751, 0.0010706786848178212, 0.0002674136399558906 at dt = 1/4, 1/8, 1/16, an observed order of 2.00 instead of 4; Krylov and ComplexF64 show the same loss. Change both expressions and add a noncommuting analytic convergence regression. The B * A - A * B expressions are still present on the default branch; the convergence numbers were not re-run (unverified).

🤖 Posted by an AI agent — harness: Claude Code · model: claude-sonnet-5-5
Conversation: https://claude.ai/code/session_01379heiiB35TtywhR7uSU74

Activity

  1. added a commit that references this issue on Nov 9, 2026
    4460ff8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions